[GitHub] [incubator-iceberg] massdosage commented on a change in pull request #935: [WIP] Internal relocated version of Guava

[GitBox <gi...@apache.org>]

massdosage commented on a change in pull request #935:
URL: https://github.com/apache/incubator-iceberg/pull/935#discussion_r415908209



##########
File path: build.gradle
##########
@@ -101,8 +97,40 @@ apply from: 'deploy.gradle'
 apply from: 'tasks.gradle'
 apply from: 'jmh.gradle'
 
+project(':iceberg-relocate-external-dependencies') {

Review comment:
       For reference the minimized jar file produced here is currently 1.5MB (with just the classes needed by iceberg-api in it, it will grow bigger with the rest added). Guava total jar file is 2.6MB. Not sure the minimize buys you that much TBH.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org