You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/24 20:52:04 UTC
[jira] [Commented] (BEAM-2066) Strip IOChannel validation calls
from file based IOs
[ https://issues.apache.org/jira/browse/BEAM-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981898#comment-15981898 ]
ASF GitHub Bot commented on BEAM-2066:
--------------------------------------
GitHub user ssisk opened a pull request:
https://github.com/apache/beam/pull/2663
[BEAM-2066] TextIO & AvroIO no longer validate schemas against IOChannelFactory
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
IOChannelFactory is no longer relevant in the new Beam FileSystem world, so using it to validate is not useful. We also expect that validation at expand time will no longer have access to pipeline options, so any future use for a manually specified validation won't be useful.
R: @dhalperi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ssisk/beam remove-validation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2663.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2663
----
commit cf96ac4e01ee1294550a3800d2f67f259e82f403
Author: Stephen Sisk <si...@google.com>
Date: 2017-04-24T19:48:41Z
TextIO & AvroIO no longer validate schemas against IOChannelFactory
----
> Strip IOChannel validation calls from file based IOs
> ----------------------------------------------------
>
> Key: BEAM-2066
> URL: https://issues.apache.org/jira/browse/BEAM-2066
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Reporter: Stephen Sisk
> Assignee: Stephen Sisk
> Priority: Minor
>
> IOs like TextIO are still calling IOChannelUtils to validate the particular spec they're given. This results in errors since in the new Beam FileSystem world, IOChannelFactory does not know about all the registered IO schemas.
> per [~dhalperi@google.com], we can just strip out this validation code - if there is an issue, we will catch it later in the read process.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)