[GitHub] [airflow] uranusjr commented on a change in pull request #22396: Fix /rendered-templates for mapped operator

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #22396:
URL: https://github.com/apache/airflow/pull/22396#discussion_r837293572



##########
File path: airflow/models/taskinstance.py
##########
@@ -1495,8 +1496,9 @@ def _update_ti_state_for_sensing(self, session=NEW_SESSION):
         # Raise exception for sensing state
         raise AirflowSmartSensorException("Task successfully registered in smart sensor.")
 
-    def _execute_task(self, context, task_copy):
+    def _execute_task(self, context, task_orig):
         """Executes Task (optionally with a Timeout) and pushes Xcom results"""
+        task_copy = self.task

Review comment:
       No you’re right, this name doesn’t really make much sense. But this is how it’s currently implemented for some reason. In `main`, `_execute_task` is only called once like this:
   
   ```python
   result = self._execute_task(context, self.task)
   ```
   
   I left the name alone to minimise diff and definitely wouldn’t object to renaming.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org