You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "yifan-c (via GitHub)" <gi...@apache.org> on 2023/08/01 16:24:57 UTC
[GitHub] [cassandra-sidecar] yifan-c commented on a diff in pull request #51: CASSANDRASC-55: Extract the in-jvm dtest template for use in other projects.
yifan-c commented on code in PR #51:
URL: https://github.com/apache/cassandra-sidecar/pull/51#discussion_r1280880325
##########
common/src/main/java/org/apache/cassandra/sidecar/cluster/InstancesConfigImpl.java:
##########
@@ -85,10 +85,12 @@ public InstanceMetadata instanceFromHost(String host) throws NoSuchElementExcept
}
catch (UnknownHostException e)
{
- throw new NoSuchElementException("Instance with host address "
- + host +
- " not found, and an error occurred when " +
- "attempting to get its IP address.");
+ NoSuchElementException error = new NoSuchElementException("Instance with host address "
+ + host +
+ " not found, and an error occurred when " +
+ "attempting to resolve its IP address.");
+ error.initCause(e);
Review Comment:
👍
##########
common/src/main/java/org/apache/cassandra/sidecar/cluster/InstancesConfigImpl.java:
##########
@@ -85,10 +85,12 @@ public InstanceMetadata instanceFromHost(String host) throws NoSuchElementExcept
}
catch (UnknownHostException e)
{
- throw new NoSuchElementException("Instance with host address "
- + host +
- " not found, and an error occurred when " +
- "attempting to get its IP address.");
+ NoSuchElementException error = new NoSuchElementException("Instance with host address "
+ + host +
+ " not found, and an error occurred when " +
+ "attempting to resolve its IP address.");
+ error.initCause(e);
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org