[jira] Commented: (THRIFT-96) TSocket.peek fails on FreeBSD

["Jérémie BORDIER (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660846#action_12660846 ] 

Jérémie BORDIER commented on THRIFT-96:
---------------------------------------

What's this issue status ? I agree with David's last comment, leaving the current version of peek in TUnderlying sounds good without changing the current behavior of TBufferedTransport. Reviewed the patch, looks good to me.

> TSocket.peek fails on FreeBSD
> -----------------------------
>
>                 Key: THRIFT-96
>                 URL: https://issues.apache.org/jira/browse/THRIFT-96
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>         Environment: FreeBSD
>            Reporter: Alexander Shigin
>         Attachments: thrift-freebsd-read.patch, thrift-peek-fix.patch, thrift-peek-fix.patch
>
>
> POSIX says what recv(2) should returns 0 if peer has performed a shutdown. This feature uses in TBufferedTransport 
> {code}
>   bool peek() {
>     if (rBase_ == rBound_) {
>       setReadBuffer(rBuf_.get(), transport_->read(rBuf_.get(), rBufSize_));
>     }
>     return (rBound_ > rBase_);
>   }
> {code}
> The decision works fine on linux, but fails on freebsd. In freebsd, recv returns -1 and errno==ECONNRESET.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.