You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by jo...@gmail.com on 2010/03/10 02:21:39 UTC

Create StyleAdjacency rewriter (issue381041)

Reviewers: shindig.remailer_gmail.com, zhoresh,

Description:
Using the Visitor paradigm, implements a rewriter that pulls all
<style>, <link rel="stylesheet"..>, and <link type="*css*"...> nodes
into <head> in document-relative order, adjacent to one another.

As noted in the comments, this maintains CSS semantics in all but the
most pathological cases while assisting in reducing browser repaints and
making concatenation operations more likely.

This CL also includes a StyleConcatContentRewriter impl using the
ConcatVisitor's CSS class.

Please review this at http://codereview.appspot.com/381041/show

Affected files:
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleAdjacencyContentRewriter.java
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleAdjacencyVisitor.java
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleConcatContentRewriter.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/DomWalkerTestBase.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleAdjacencyContentRewriterTest.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleAdjacencyVisitorTest.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleConcatContentRewriterTest.java