You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/03/01 20:43:12 UTC
Review Request 44219: Complete TODO in Tasks.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/
-----------------------------------------------------------
Review request for Aurora and John Sirois.
Repository: aurora
Description
-------
This completes the TODO in Tasks.java by removing the unused code.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
Diff: https://reviews.apache.org/r/44219/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 44219: Complete TODO in Tasks.java
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/#review121480
-----------------------------------------------------------
Master (8f98e6e) is red with this patch.
./build-support/jenkins/build.sh
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/base/Tasks.java:18:8: error: Unused import - java.util.Map.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/base/Tasks.java:27:8: error: Unused import - com.google.common.collect.Maps.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/base/Tasks.java:33:8: error: Unused import - org.apache.aurora.gen.ScheduledTask.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 51.277 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 1, 2016, 7:43 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44219/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 7:43 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This completes the TODO in Tasks.java by removing the unused code.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
>
> Diff: https://reviews.apache.org/r/44219/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 44219: Complete TODO in Tasks.java
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/#review121522
-----------------------------------------------------------
Master (8f98e6e) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
[1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7f180837a5d0>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7f180837a210>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f180837a210>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f180837a210>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7f180837a210>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f180837a210>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7f180837a210>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7f180837a210>] Time now: 1.502
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 660 passed, 5 skipped, 1 warnings in 278.12 seconds [0m
FAILURE
22:21:09 05:34 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 1, 2016, 10:04 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44219/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 10:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This completes the TODO in Tasks.java by removing the unused code.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
>
> Diff: https://reviews.apache.org/r/44219/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 44219: Complete TODO in Tasks.java
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/#review121533
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On March 1, 2016, 11:04 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44219/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 11:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This completes the TODO in Tasks.java by removing the unused code.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
>
> Diff: https://reviews.apache.org/r/44219/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 44219: Complete TODO in Tasks.java
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/
-----------------------------------------------------------
(Updated March 1, 2016, 2:04 p.m.)
Review request for Aurora and John Sirois.
Repository: aurora
Description
-------
This completes the TODO in Tasks.java by removing the unused code.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
Diff: https://reviews.apache.org/r/44219/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 44219: Complete TODO in Tasks.java
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/#review121506
-----------------------------------------------------------
Master (8f98e6e) is red with this patch.
./build-support/jenkins/build.sh
+ date
Tue Mar 1 21:38:56 UTC 2016
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not open proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj).
> Timeout waiting to lock proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj). It is currently in use by another Gradle instance.
Owner PID: unknown
Our PID: 20690
Owner Operation: unknown
Our operation: Initialize cache
Lock file: /home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/proj/cache.properties.lock
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 29.605 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 1, 2016, 9:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44219/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 9:21 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This completes the TODO in Tasks.java by removing the unused code.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
>
> Diff: https://reviews.apache.org/r/44219/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 44219: Complete TODO in Tasks.java
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/
-----------------------------------------------------------
(Updated March 1, 2016, 1:21 p.m.)
Review request for Aurora and John Sirois.
Changes
-------
Style fixes.
Repository: aurora
Description
-------
This completes the TODO in Tasks.java by removing the unused code.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8
Diff: https://reviews.apache.org/r/44219/diff/
Testing
-------
Thanks,
Zameer Manji