You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/16 17:28:26 UTC

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #3019: ARTEMIS-2658 AMQP message read from page has wrong encode size

franz1981 edited a comment on issue #3019: ARTEMIS-2658 AMQP message read from page has wrong encode size
URL: https://github.com/apache/activemq-artemis/pull/3019#issuecomment-599664538
 
 
   @clebertsuconic I'm not very proud of https://github.com/apache/activemq-artemis/pull/3019/commits/2105479304a7efead14ecb343686bf31042f1731#diff-d3a97ffe6cb7d4ab3fd0c4d24dea022bR100, but it seems covered by some existing tests eg `AmqpBridgeClusterRedistributionTest`. This change should preserve the nice performance of https://issues.apache.org/jira/browse/ARTEMIS-2617: I'm now running a test to verify it.
   @tabish121 is aware of this issue ie duplicate decoding of  `address` : I'm thinking to create a `AMQPMessagePersisterV3` that save the encoding/decoding of `address` to happen twice, while "fixing" `AMQPMessagePersisterV2` trying to preserve the nice optimization on journal loading. wdyt? advices?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services