You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/24 12:19:58 UTC

[jira] [Commented] (NIFI-2729) testSendSuccessWithProxy frequently timing out in travis-ci

    [ https://issues.apache.org/jira/browse/NIFI-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693142#comment-15693142 ] 

ASF GitHub Bot commented on NIFI-2729:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1270

    NIFI-2729: testSendSuccessWithProxy timeout in Travis

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    - Changed AtomicBoolean to CountDownLatch to avoid sleeping thread in
      some test cases
    - Specified less number of threads for Jetty and LittleProxy than
      default to lower resource usage
    - Added try catch for the specific gateway timeout case (504) so that
      test can pass even it happens while it fails with other errors

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-2729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1270
    
----
commit 0ba284e0a2cecee8073abb466070275223de1de7
Author: Koji Kawamura <ij...@apache.org>
Date:   2016-11-24T12:17:04Z

    NIFI-2729: testSendSuccessWithProxy timeout in Travis
    
    - Changed AtomicBoolean to CountDownLatch to avoid sleeping thread in
      some test cases
    - Specified less number of threads for Jetty and LittleProxy than
      default to lower resource usage
    - Added try catch for the specific gateway timeout case (504) so that
      test can pass even it happens while it fails with other errors

----


> testSendSuccessWithProxy frequently timing out in travis-ci
> -----------------------------------------------------------
>
>                 Key: NIFI-2729
>                 URL: https://issues.apache.org/jira/browse/NIFI-2729
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Andre
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)