You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/04/04 13:28:56 UTC
[GitHub] [yunikorn-k8shim] zhuqi-lucas opened a new pull request, #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
zhuqi-lucas opened a new pull request, #568:
URL: https://github.com/apache/yunikorn-k8shim/pull/568
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on a diff in pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on code in PR #568:
URL: https://github.com/apache/yunikorn-k8shim/pull/568#discussion_r1158484716
##########
deployments/image/webtest/Dockerfile:
##########
@@ -15,23 +15,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG ARCH=
-FROM ${ARCH}nginx:stable-alpine
-
-# Home location for all data and configs
-ENV HOME=/opt/yunikorn
+# Imagestage: use scratch base image
+FROM --platform=$TARGETPLATFORM scratch
+COPY --chown=4444:0 document/index.html /html/
Review Comment:
Looks good. Will +1 once we get clean e2e runs (may take a while as we've got some test flakiness).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #568:
URL: https://github.com/apache/yunikorn-k8shim/pull/568#issuecomment-1496014787
## [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#568](https://codecov.io/gh/apache/yunikorn-k8shim/pull/568?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa663e3) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/9d73850e4dc4979d97cf39fe9e701f0d18b8c878?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d73850) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 69.92% 69.92%
=======================================
Files 46 46
Lines 7890 7890
=======================================
Hits 5517 5517
Misses 2169 2169
Partials 204 204
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on a diff in pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on code in PR #568:
URL: https://github.com/apache/yunikorn-k8shim/pull/568#discussion_r1158470831
##########
deployments/image/webtest/Dockerfile:
##########
@@ -15,23 +15,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG ARCH=
-FROM ${ARCH}nginx:stable-alpine
-
-# Home location for all data and configs
-ENV HOME=/opt/yunikorn
+# Imagestage: use scratch base image
+FROM --platform=$TARGETPLATFORM scratch
+COPY --chown=4444:0 document/index.html /html/
Review Comment:
Use `--chown=0:0` here. There's no need to make the content owned by the web user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] zhuqi-lucas commented on a diff in pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #568:
URL: https://github.com/apache/yunikorn-k8shim/pull/568#discussion_r1158481260
##########
deployments/image/webtest/Dockerfile:
##########
@@ -15,23 +15,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG ARCH=
-FROM ${ARCH}nginx:stable-alpine
-
-# Home location for all data and configs
-ENV HOME=/opt/yunikorn
+# Imagestage: use scratch base image
+FROM --platform=$TARGETPLATFORM scratch
+COPY --chown=4444:0 document/index.html /html/
Review Comment:
@craigcondit It makes sense, addressed now, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
URL: https://github.com/apache/yunikorn-k8shim/pull/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] zhuqi-lucas commented on pull request #568: [YUNIKORN-1677] move to simple go based web server for e2e tests.
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #568:
URL: https://github.com/apache/yunikorn-k8shim/pull/568#issuecomment-1497392191
Thank you @craigcondit for review, addressed the comments now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org