[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1276: [CALCITE-3137] AssertionError when reconstructing STRUCTURED type fields

[GitBox <gi...@apache.org>]

XuQianJin-Stars commented on a change in pull request #1276: [CALCITE-3137] AssertionError when reconstructing STRUCTURED type fields
URL: https://github.com/apache/calcite/pull/1276#discussion_r303493995
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/fun/SqlNewOperator.java
 ##########
 @@ -49,6 +50,14 @@ public SqlNode rewriteCall(SqlValidator validator, SqlCall call) {
   public boolean requiresDecimalExpansion() {
     return false;
   }
+
+  @Override public boolean validRexOperands(int count, Litmus litmus) {
+    if (count <= 0) {
+      return litmus.fail("wrong operand count {} for {}, Need at least one RexOperand!",
+          count, this);
+    }
+    return litmus.succeed();
+  }
 
 Review comment:
   hi @danny0405  Thank you very much,Let me know more about it.I address commits for this pr.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services