You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/14 10:43:56 UTC
Review Request 62326: Always send TASK_KILLED when the task is killed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62326/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description
-------
Always send TASK_KILLED when the task is killed.
Diffs
-----
src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529
src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082
Diff: https://reviews.apache.org/r/62326/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 62326: Always send TASK_KILLED when the task is
killed.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62326/#review186694
-----------------------------------------------------------
Ship it!
Summary "Always send TASK_KILLED when the task is killed by a framework."
Description: This change is done for command, docker and default executors.
- Vinod Kone
On Sept. 29, 2017, 7:33 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62326/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 7:33 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Always send TASK_KILLED when the task is killed.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559
> src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0
> src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4
>
>
> Diff: https://reviews.apache.org/r/62326/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62326: Always send TASK_KILLED when the task is
killed.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62326/#review186697
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On Sept. 29, 2017, 12:33 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62326/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 12:33 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Always send TASK_KILLED when the task is killed.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559
> src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0
> src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4
>
>
> Diff: https://reviews.apache.org/r/62326/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62326: Always send TASK_KILLED when the task is
killed by a framework.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62326/
-----------------------------------------------------------
(Updated Oct. 16, 2017, 4:21 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description
-------
This change is done for command, docker and default executors.
Diffs (updated)
-----
src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559
src/launcher/default_executor.cpp e58766fed88ff949f2ff268433c3857f68bcc13a
src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4
Diff: https://reviews.apache.org/r/62326/diff/4/
Changes: https://reviews.apache.org/r/62326/diff/3-4/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 62326: Always send TASK_KILLED when the task is
killed by a framework.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62326/
-----------------------------------------------------------
(Updated Oct. 4, 2017, 11:43 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Addressed review comments.
Summary (updated)
-----------------
Always send TASK_KILLED when the task is killed by a framework.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description (updated)
-------
This change is done for command, docker and default executors.
Diffs (updated)
-----
src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559
src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0
src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4
Diff: https://reviews.apache.org/r/62326/diff/3/
Changes: https://reviews.apache.org/r/62326/diff/2-3/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 62326: Always send TASK_KILLED when the task is
killed.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62326/
-----------------------------------------------------------
(Updated Sept. 29, 2017, 3:33 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description
-------
Always send TASK_KILLED when the task is killed.
Diffs
-----
src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559
src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0
src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4
Diff: https://reviews.apache.org/r/62326/diff/2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 62326: Always send TASK_KILLED when the task is
killed.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62326/
-----------------------------------------------------------
(Updated Sept. 29, 2017, 2:55 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Updated Docker executor as well.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description
-------
Always send TASK_KILLED when the task is killed.
Diffs (updated)
-----
src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559
src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0
src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4
Diff: https://reviews.apache.org/r/62326/diff/2/
Changes: https://reviews.apache.org/r/62326/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang