[GitHub] [couchdb-nano] glynnbird opened a new pull request, #320: fix cookie handling bug

[GitBox <gi...@apache.org>]

glynnbird opened a new pull request, #320:
URL: https://github.com/apache/couchdb-nano/pull/320

   ## Overview
   
   In issue https://github.com/apache/couchdb-nano/issues/174#issuecomment-1378427726 it was pointed out that cookie authentication seemed to be broken. I checked and it seemed to be the case.
   
   I updated the dependencies and checked the implementation of Axios's cookie handling.
   
   This problem is now fixed so you can do:
   
   ```js
   const Nano = require('nano')
   const nano = Nano('http://127.0.0.1:5984')
   
   const main = async () => {
     await nano.auth('myusername', 'mypassword')
     const r = await nano.db.list()
   }
   main()
   ```
   
   ## Testing recommendations
   
   - Don't provide creds in the URL, use `nano.auth` instead
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird merged pull request #320: fix cookie handling bug

[GitBox <gi...@apache.org>]

glynnbird merged PR #320:
URL: https://github.com/apache/couchdb-nano/pull/320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org