You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekagarwal87 (via GitHub)" <gi...@apache.org> on 2023/06/19 06:57:53 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request, #14445: Skip tests based on files changed in the PR
abhishekagarwal87 opened a new pull request, #14445:
URL: https://github.com/apache/druid/pull/14445
Our CI system has a lot of tests. And much of this testing is really unnecessary for most of the PRs. This PR adds some checks so we can skip these expensive tests when we know they are not necessary.
I have ensured that
- All the tests always run on the feature branch
- In unit tests, we skip jobs when we know that there are no changes outside extensions
- In standard ITs, it was hard to associate an IT group with a bunch of extensions. So I rather tried to improve life for building some of the active extensions such as MSQ, MM-less ingestion.
Marking it draft as I am still testing it.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a diff in pull request #14445: Skip tests based on files changed in the PR
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on code in PR #14445:
URL: https://github.com/apache/druid/pull/14445#discussion_r1236675795
##########
integration-tests/docker/environment-configs/test-groups/shuffle-deep-store:
##########
@@ -19,5 +19,6 @@
# Test with deep storage as intermediate location to store shuffle data
# Local deep storage will be used here
+# If you are making a change in load list below, make the necessary changes in github actions too
Review Comment:
i wonder if it would be possible to feed these into the gha as an input of whether or not to run the test (not a blocker for this PR, im just a bit nervous about keeping these things synced)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #14445: Skip tests based on files changed in the PR
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #14445:
URL: https://github.com/apache/druid/pull/14445#discussion_r1236737991
##########
integration-tests/docker/environment-configs/test-groups/shuffle-deep-store:
##########
@@ -19,5 +19,6 @@
# Test with deep storage as intermediate location to store shuffle data
# Local deep storage will be used here
+# If you are making a change in load list below, make the necessary changes in github actions too
Review Comment:
Yes. that would have been nice though will require a bit more work :) FWIW, the tests will run in full on a branch so it wouldn't be too long before we learn if something broke.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #14445: Skip tests based on files changed in the PR
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #14445:
URL: https://github.com/apache/druid/pull/14445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org