You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Paul Gier (JIRA)" <ji...@codehaus.org> on 2007/12/14 23:43:57 UTC
[jira] Created: (MNG-3321) Skip plugin and/or execution
Skip plugin and/or execution
----------------------------
Key: MNG-3321
URL: http://jira.codehaus.org/browse/MNG-3321
Project: Maven 2
Issue Type: New Feature
Components: Command Line
Affects Versions: 2.0.8
Reporter: Paul Gier
Add ability to skip the execution of certain plugins. From the command line this could look something like:
{code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
{code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3321) Skip plugin and/or execution
Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Rosenvold updated MNG-3321:
------------------------------------
Fix Version/s: (was: Issues to be reviewed for 3.x)
3.1
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: 3.1
>
> Attachments: MNG-3321-core-integration-testing.patch, MNG-3321-maven-core.patch, MNG-3321-maven-core.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3321) Skip plugin and/or execution
Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253297#action_253297 ]
Kristian Rosenvold commented on MNG-3321:
-----------------------------------------
Kalyan; thanks for the patch, which I think looks very good, the unit tests were good. I have a few comments:
1. License headers must be added to all the new files.
2. Any features added to core also have corresponding integration tests, which are in a separate project (https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk). In this case I believe the tests should cover skipping plugin and execution and demonstrate end-to-end effect of the feature. We do not commit new features such as this without such tests.
3. Documentation. This needs to be added to the documentation, somewhere ;)
4. Code style. This is only a minor issue but if you use the ide-templates at http://maven.apache.org/developers/committer-environment.html while making patches, your patch will
follow maven code style. In general this makes the patch easier to apply and reduce the risk of patch rot.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: MNG-3321-maven-core.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3321) Skip plugin and/or execution
Posted by "Kalyan C. Akella (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=252959#action_252959 ]
Kalyan C. Akella commented on MNG-3321:
---------------------------------------
I am working on this issue right now. Will update my progress on the dev list.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: Issues to be reviewed for 3.x
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3321) Skip plugin and/or execution
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3321:
------------------------------
Fix Version/s: 2.x
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: 2.x
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3321) Skip plugin and/or execution
Posted by "Kalyan C. Akella (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalyan C. Akella updated MNG-3321:
----------------------------------
Attachment: MNG-3321-core-integration-testing.patch
MNG-3321-maven-core.patch
MNG-3321-maven-model.patch
Attaching the revised patches that implement the following:
1. ability to skip multiple plugin executions at CLI,
2. ability to skip plugins & their executions in POM using the <skip> element
I also attached the same patches to the related issue, MNG-3102 with the same patch file names.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: 3.1
>
> Attachments: MNG-3321-core-integration-testing.patch, MNG-3321-core-integration-testing.patch, MNG-3321-maven-core.patch, MNG-3321-maven-core.patch, MNG-3321-maven-core.patch, MNG-3321-maven-model.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3321) Skip plugin and/or execution
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton updated MNG-3321:
---------------------------------
Assignee: (was: Vincent Siveton)
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3321) Skip plugin and/or execution
Posted by "Kalyan C. Akella (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalyan C. Akella updated MNG-3321:
----------------------------------
Attachment: MNG-3321-core-integration-testing.patch
MNG-3321-maven-core.patch
Thank you for the comments. Attaching the patch files with the following changes,
1. Added the license headers.
2. Added integration tests. Tests for normal execution when no skip.plugin property specified, skipping of plugin & skipping of an execution within a plugin.
3. Fixed the code style to use the maven project settings in my IDE.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: MNG-3321-core-integration-testing.patch, MNG-3321-maven-core.patch, MNG-3321-maven-core.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3321) Skip plugin and/or execution
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton closed MNG-3321.
--------------------------------
Assignee: Vincent Siveton
Resolution: Duplicate
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Assignee: Vincent Siveton
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3321) Skip plugin and/or execution
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116875 ]
Paul Gier commented on MNG-3321:
--------------------------------
Additionally, maybe multiple plugins could be skipped by passing a comma separated list. Like this:
mvn -Dskip.plugins=org.apache.maven.plugins:maven-surefire-plugin,org.apache.maven.plugins:maven-jar-plugin install
The same syntax could be applied to skipping individual executions.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MNG-3321) Skip plugin and/or execution
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier reopened MNG-3321:
----------------------------
I don't think this is a duplicate of MNG-3102. While the two issues are related, they are not the same. I would like to be able to skip certain plugins and/or executions of plugins from the command line without having to modify the pom.
This could be used for things like running only one of several surefire configurations (yes, I know this can be done with profiles, but it would be a lot cleaner this way IMO), or skipping just the test part of the build but still compiling the tests.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Assignee: Vincent Siveton
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3321) Skip plugin and/or execution
Posted by "Kalyan C. Akella (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalyan C. Akella updated MNG-3321:
----------------------------------
Attachment: MNG-3321-maven-core.patch
Attaching the patch that implements this feature. The patch modifies execution plan calculation algorithm to eliminate plugins & their executions that need to be skipped.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: MNG-3321-maven-core.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3321) Skip plugin and/or execution
Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253778#action_253778 ]
Kristian Rosenvold commented on MNG-3321:
-----------------------------------------
I'm leaving this issue assigned to "3.1", and requesting that interested parties attach use cases to this issue. The dev list discussion is at
http://mail-archives.apache.org/mod_mbox/maven-dev/201101.mbox/%3CAANLkTi=DJx9q-qEd+sQ2-41Y-iK0G4cj0EhLaLMON-BJ@mail.gmail.com%3E
and http://mail-archives.apache.org/mod_mbox/maven-dev/201102.mbox/%3CAANLkTikdjE+FLd4K-0s1-R-F9MhsK-vdqnYGF57QkByd@mail.gmail.com%3E
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: 3.1
>
> Attachments: MNG-3321-core-integration-testing.patch, MNG-3321-maven-core.patch, MNG-3321-maven-core.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3321) Skip plugin and/or execution
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253766#action_253766 ]
John Casey commented on MNG-3321:
---------------------------------
I've noted this on the dev@ ML, but I'll add a short comment here as well.
I think this is a great idea, and I like the approach of the patch. However, I'd like to see us take it a little further before we consider releasing a version of Maven with this patch in place. I'd like to have an option to trigger plugin/execution suppression from somewhere in the POM, not just via CLI option. This allows us to say, "My build uses the jar packaging, but I never want the X plugin to run."
To me, this is important because it means we don't have to worry about users getting the right CLI options in place to run a build (or, more importantly, a release). In many cases, failing to use the suppressing CLI option may break the build, but in others it may lead to incorrect build results being released for public consumption. Also, in cases where it's important that users can rebuild the project from source (as in cases where ASF votes are taken), requiring a CLI option to produce a correct build adds a new layer of build complexity. It takes us away from the common vocabulary that makes Maven so effective, and back toward something more like Ant, where you have to know the correct incantation to produce a build.
I hope this patch is applied, but I think we need to spend a little more time focusing on how to codify these suppressions in the POM before releasing a Maven version with this patch in place.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: 3.1
>
> Attachments: MNG-3321-core-integration-testing.patch, MNG-3321-maven-core.patch, MNG-3321-maven-core.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin install {code}
> Also useful would be the ability to skip individual executions of a plugin. For example, if the surefire plugin had two executions defined as "ex1" and "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1 install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira