You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/02/19 15:51:56 UTC
[GitHub] [cassandra] iamaleksey commented on a change in pull request #898: Cassandra 16435 trunk
iamaleksey commented on a change in pull request #898:
URL: https://github.com/apache/cassandra/pull/898#discussion_r579285754
##########
File path: src/java/org/apache/cassandra/db/filter/ClusteringIndexSliceFilter.java
##########
@@ -56,6 +56,20 @@ public boolean selectsAllPartition()
return slices.size() == 1 && !slices.hasLowerBound() && !slices.hasUpperBound();
}
+ public boolean isEmpty(ClusteringComparator comparator)
+ {
+ if (slices.isEmpty())
+ return true;
+
+ for (Slice slice : slices)
+ {
+ if (slice.isEmpty(comparator))
+ return true;
Review comment:
This is a bit wrong, if only one or some of the slices is empty, but not all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org