You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/09/01 08:52:10 UTC

[GitHub] [cordova-plugin-inappbrowser] ravicini opened a new pull request #899: New android only flag to keep screen on

ravicini opened a new pull request #899:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/899


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   We have a scenario where we show a page to the user with the in app browser and like to keep the screen on during that page.
   The in app browser helps us got achieve an illusion that the screen is a part of the app.
   
   @Hermarcel wrote a different scenario in the issue linked below.
   Closes #876 
   
   
   ### Description
   <!-- Describe your changes in detail -->
   I've added a in app browser option flag to keep the screen on.
   New flag: `keepscreenon`
   Default: not enabled
   Sets Android window flag: `WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON)`
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   I've performed the changes in our app first and tested it on a device.
   - Set Screen timeout to 15s
   - Navigating to the page -> screen keeps on
   - Navigating back to the app -> flag gets cleared -> screen timeout works again
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org