[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #8706: [Feature][Login] Add SSO login by Casdoor

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #8706:
URL: https://github.com/apache/dolphinscheduler/pull/8706#discussion_r1040425542


##########
dolphinscheduler-ui/src/views/login/index.tsx:
##########
@@ -127,6 +143,19 @@ const login = defineComponent({
               {this.t('login.login')}
             </NButton>
           </div>
+          <div class={styles['form-model']} v-show={this.loginForm.ssoLoginUrl.length !== 0}>
+            <a href={this.loginForm.ssoLoginUrl} style="text-decoration:none">
+              <NButton
+                  class='btn-login'

Review Comment:
   Seems you should change this class name, because it had exist the same class and e2e will find it  when login.
   https://github.com/apache/dolphinscheduler/blob/8a152aebc70f57cc400c1cd8b16991817bed0d0e/dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/LoginPage.java#L36-L50



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org