You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wangnimaa (GitHub)" <gi...@apache.org> on 2019/04/10 06:26:47 UTC

[GitHub] [incubator-dubbo] wangnimaa commented on issue #3651: code rule

> I agree with uniform coding rules. But I personally more prefer use tool to make sure necessary code rule is applied to project.
> 
> I think we need discuss what rule we need apply, for example, I see some Override was added. If we agree to must have Override annotation, we should add a checkstyle rule (if rule existed)
> Another example is allow single-line statements without braces or not, it also something need discuss

last year ,I propose this issue ,https://github.com/apache/incubator-dubbo/issues/2553.we discuss about the issues .I've been solving these problems.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3651 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org