You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sb...@apache.org on 2016/12/06 08:40:09 UTC
[12/50] ignite git commit: IGNITE-4279: Fixed most of the failures in
JDBC suite. They were caused by connection leak in old test
JdbcNoDefaultCacheTest.
IGNITE-4279: Fixed most of the failures in JDBC suite. They were caused by connection leak in old test JdbcNoDefaultCacheTest.
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/43ec85f2
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/43ec85f2
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/43ec85f2
Branch: refs/heads/ignite-comm-balance-master
Commit: 43ec85f2be5bc4b18f3cff6630d5adef60930fdc
Parents: ccbe600
Author: devozerov <vo...@gridgain.com>
Authored: Fri Nov 25 13:55:50 2016 +0300
Committer: devozerov <vo...@gridgain.com>
Committed: Fri Nov 25 13:55:50 2016 +0300
----------------------------------------------------------------------
.../internal/jdbc2/JdbcNoDefaultCacheTest.java | 40 ++++++++++----------
1 file changed, 21 insertions(+), 19 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ignite/blob/43ec85f2/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcNoDefaultCacheTest.java
----------------------------------------------------------------------
diff --git a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcNoDefaultCacheTest.java b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcNoDefaultCacheTest.java
index 0acaa05..cdcda48 100644
--- a/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcNoDefaultCacheTest.java
+++ b/modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcNoDefaultCacheTest.java
@@ -127,35 +127,37 @@ public class JdbcNoDefaultCacheTest extends GridCommonAbstractTest {
public void testNoCacheNameQuery() throws Exception {
Statement stmt;
- stmt = DriverManager.getConnection(CFG_URL_PREFIX + CFG_URL).createStatement();
+ try (Connection conn = DriverManager.getConnection(CFG_URL_PREFIX + CFG_URL)) {
+ stmt = conn.createStatement();
- assertNotNull(stmt);
- assertFalse(stmt.isClosed());
+ assertNotNull(stmt);
+ assertFalse(stmt.isClosed());
- stmt.execute("select t._key, t._val from \"cache1\".Integer t");
+ stmt.execute("select t._key, t._val from \"cache1\".Integer t");
- ResultSet rs = stmt.getResultSet();
+ ResultSet rs = stmt.getResultSet();
- while(rs.next())
- assertEquals(rs.getInt(2), rs.getInt(1) * 2);
+ while(rs.next())
+ assertEquals(rs.getInt(2), rs.getInt(1) * 2);
- stmt.execute("select t._key, t._val from \"cache2\".Integer t");
+ stmt.execute("select t._key, t._val from \"cache2\".Integer t");
- rs = stmt.getResultSet();
+ rs = stmt.getResultSet();
- while(rs.next())
- assertEquals(rs.getInt(2), rs.getInt(1) * 3);
+ while(rs.next())
+ assertEquals(rs.getInt(2), rs.getInt(1) * 3);
- stmt.execute("select t._key, t._val, v._val " +
- "from \"cache1\".Integer t join \"cache2\".Integer v on t._key = v._key");
+ stmt.execute("select t._key, t._val, v._val " +
+ "from \"cache1\".Integer t join \"cache2\".Integer v on t._key = v._key");
- rs = stmt.getResultSet();
+ rs = stmt.getResultSet();
- while(rs.next()) {
- assertEquals(rs.getInt(2), rs.getInt(1) * 2);
- assertEquals(rs.getInt(3), rs.getInt(1) * 3);
- }
+ while(rs.next()) {
+ assertEquals(rs.getInt(2), rs.getInt(1) * 2);
+ assertEquals(rs.getInt(3), rs.getInt(1) * 3);
+ }
- stmt.close();
+ stmt.close();
+ }
}
}