[GitHub] [kafka] ahuang98 commented on a diff in pull request #14206: [MINOR] More image replay test cases

["ahuang98 (via GitHub)" <gi...@apache.org>]

ahuang98 commented on code in PR #14206:
URL: https://github.com/apache/kafka/pull/14206#discussion_r1339224472


##########
metadata/src/test/java/org/apache/kafka/image/FeaturesImageTest.java:
##########
@@ -96,6 +121,20 @@ public void testImage2RoundTrip() {
         testToImage(IMAGE2);
     }
 
+    @Test
+    public void testImage3RoundTrip() {
+        testToImage(IMAGE3);
+    }
+
+    @Test
+    public void testApplyDelta2() {
+        assertEquals(IMAGE3, DELTA2.apply());
+        // check image2 + delta2 = image3, since records for image2 + delta2 might differ from records from image3
+        List<ApiMessageAndVersion> records = getImageRecords(IMAGE3);

Review Comment:
   thanks for catching this, think it makes sense to me that this would pass - the records from delta2 applied ontop of image3 still come out to image3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org