You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by te...@apache.org on 2022/10/13 01:51:57 UTC
[pulsar] branch master updated: Avoid unnecessary creation of BitSetRecyclable objects (#17998)
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 6c65ca0d8a8 Avoid unnecessary creation of BitSetRecyclable objects (#17998)
6c65ca0d8a8 is described below
commit 6c65ca0d8a80bfaaa4d5869e0cea485f5c94369b
Author: LinChen <15...@qq.com>
AuthorDate: Thu Oct 13 09:51:48 2022 +0800
Avoid unnecessary creation of BitSetRecyclable objects (#17998)
Co-authored-by: leolinchen <le...@tencent.com>
---
.../org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
index b67c74fdc79..20f760d893a 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
@@ -2188,11 +2188,12 @@ public class ManagedCursorImpl implements ManagedCursor {
individualDeletedMessages);
}
} else if (config.isDeletionAtBatchIndexLevelEnabled() && batchDeletedIndexes != null) {
- BitSetRecyclable bitSet = batchDeletedIndexes.computeIfAbsent(position, (v) ->
- BitSetRecyclable.create().resetWords(position.ackSet));
BitSetRecyclable givenBitSet = BitSetRecyclable.create().resetWords(position.ackSet);
- bitSet.and(givenBitSet);
- givenBitSet.recycle();
+ BitSetRecyclable bitSet = batchDeletedIndexes.computeIfAbsent(position, (v) -> givenBitSet);
+ if (givenBitSet != bitSet) {
+ bitSet.and(givenBitSet);
+ givenBitSet.recycle();
+ }
if (bitSet.isEmpty()) {
PositionImpl previousPosition = ledger.getPreviousPosition(position);
individualDeletedMessages.addOpenClosed(previousPosition.getLedgerId(),