You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/09 20:24:21 UTC

[GitHub] [spark] MaxGekk opened a new pull request #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

MaxGekk opened a new pull request #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172
 
 
   ### What changes were proposed in this pull request?
   In the PR, I propose to fallback to rebasing via local dates for dates of before common era (BCE). 
   
   ### Why are the changes needed?
   It fixes the bug of rebasing dates of BCE.
   
   ### Does this PR introduce any user-facing change?
   Yes
   
   ### How was this patch tested?
   - By existing tests in `RebaseDateTimeSuite` and `DateTimeUtilsSuite`
   - Added tests for negative years to `RebaseDateTimeSuite`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611737370
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612643219
 
 
   @cloud-fan @HyukjinKwon @dongjoon-hyun Please, review this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611824605
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612022945
 
 
   **[Test build #121079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121079/testReport)** for PR 28172 at commit [`59a9691`](https://github.com/apache/spark/commit/59a9691db64a59f7c71751e82d94e6847a96ae4f).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612257456
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121100/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612256989
 
 
   **[Test build #121100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121100/testReport)** for PR 28172 at commit [`68cebb9`](https://github.com/apache/spark/commit/68cebb9696f6f43003e105f4890a1b43894663f7).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611981419
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612045418
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612165439
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#discussion_r407332732
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala
 ##########
 @@ -66,15 +66,53 @@ object RebaseDateTime {
   // The starting point is the `0001-01-01` (-719164 days since the epoch in
   // Julian calendar). All dates before the staring point have the same difference
   // of 2 days in Julian and Proleptic Gregorian calendars.
 
 Review comment:
   shall we remove `All dates before the staring point have the same difference ...`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612165448
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121093/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611824612
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121045/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611981423
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25769/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612766537
 
 
   thanks, merging to master/3.0!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611737381
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25736/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611737370
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612167707
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612048959
 
 
   **[Test build #121093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121093/testReport)** for PR 28172 at commit [`59a9691`](https://github.com/apache/spark/commit/59a9691db64a59f7c71751e82d94e6847a96ae4f).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612023177
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611736351
 
 
   **[Test build #121045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121045/testReport)** for PR 28172 at commit [`09b1315`](https://github.com/apache/spark/commit/09b1315000b6187239deeba8ddaea50e8e15942d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612165448
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121093/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612167715
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25790/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612257449
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#discussion_r407333073
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala
 ##########
 @@ -100,15 +142,46 @@ object RebaseDateTime {
   // The starting point is the `0001-01-01` (-719162 days since the epoch in
   // Proleptic Gregorian calendar). All dates before the staring point have the same
   // difference of -2 days in Proleptic Gregorian and Julian calendars.
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612023177
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611981743
 
 
   @cloud-fan @HyukjinKwon Please, take a look at the fix for rebasing negative years.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612164683
 
 
   **[Test build #121093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121093/testReport)** for PR 28172 at commit [`59a9691`](https://github.com/apache/spark/commit/59a9691db64a59f7c71751e82d94e6847a96ae4f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612257449
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611824612
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121045/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611981419
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612023196
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121079/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612165439
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612167060
 
 
   **[Test build #121100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121100/testReport)** for PR 28172 at commit [`68cebb9`](https://github.com/apache/spark/commit/68cebb9696f6f43003e105f4890a1b43894663f7).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612048959
 
 
   **[Test build #121093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121093/testReport)** for PR 28172 at commit [`59a9691`](https://github.com/apache/spark/commit/59a9691db64a59f7c71751e82d94e6847a96ae4f).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612045999
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611981423
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25769/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611824100
 
 
   **[Test build #121045 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121045/testReport)** for PR 28172 at commit [`09b1315`](https://github.com/apache/spark/commit/09b1315000b6187239deeba8ddaea50e8e15942d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612023196
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121079/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612167715
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25790/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612167707
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611981107
 
 
   **[Test build #121079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121079/testReport)** for PR 28172 at commit [`59a9691`](https://github.com/apache/spark/commit/59a9691db64a59f7c71751e82d94e6847a96ae4f).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611736351
 
 
   **[Test build #121045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121045/testReport)** for PR 28172 at commit [`09b1315`](https://github.com/apache/spark/commit/09b1315000b6187239deeba8ddaea50e8e15942d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612046006
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25783/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612167060
 
 
   **[Test build #121100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121100/testReport)** for PR 28172 at commit [`68cebb9`](https://github.com/apache/spark/commit/68cebb9696f6f43003e105f4890a1b43894663f7).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612045999
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611737381
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25736/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611981107
 
 
   **[Test build #121079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121079/testReport)** for PR 28172 at commit [`59a9691`](https://github.com/apache/spark/commit/59a9691db64a59f7c71751e82d94e6847a96ae4f).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28172: [WIP][SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-611824605
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#issuecomment-612257456
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121100/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates
URL: https://github.com/apache/spark/pull/28172#issuecomment-612046006
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25783/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28172: [SPARK-31402][SQL] Fix rebasing of BCE dates/timestamps
URL: https://github.com/apache/spark/pull/28172#discussion_r407334127
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala
 ##########
 @@ -66,15 +66,53 @@ object RebaseDateTime {
   // The starting point is the `0001-01-01` (-719164 days since the epoch in
   // Julian calendar). All dates before the staring point have the same difference
   // of 2 days in Julian and Proleptic Gregorian calendars.
 
 Review comment:
   For this particular array, it is valid comment. It is not valid for `rebaseJulianToGregorianDays`, strictly speaking.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org