You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/11/30 22:31:00 UTC

[GitHub] rabbah commented on a change in pull request #2991: controller creates health and cacheInvalidation topics

rabbah commented on a change in pull request #2991: controller creates health and cacheInvalidation topics
URL: https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154220992
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/connector/kafka/KafkaMessagingProvider.scala
 ##########
 @@ -46,15 +57,14 @@ object KafkaMessagingProvider extends MessagingProvider {
   def getProducer(config: WhiskConfig, ec: ExecutionContext)(implicit logging: Logging): MessageProducer =
     new KafkaProducerConnector(config.kafkaHosts, ec)
 
-  def ensureTopic(config: WhiskConfig, topic: String, topicConfig: Map[String, String])(
-    implicit logging: Logging): Boolean = {
+  def ensureTopic(config: WhiskConfig, topic: String, topicConfig: String)(implicit logging: Logging): Boolean = {
 
 Review comment:
   Is config still needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services