[jira] [Comment Edited] (OAK-1181) Review node type definition for oak:queryIndexDefinition

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821794#comment-13821794 ] 

angela edited comment on OAK-1181 at 11/13/13 8:29 PM:
-------------------------------------------------------

in this case i would suggest to define oak:queryIndexDefinition as follows:

{code}
/**
* Index definitions storage
*
* @since oak 0.6
*/
[oak:QueryIndexDefinition]
  - * (UNDEFINED) IGNORE
  - * (UNDEFINED) multiple IGNORE
  + * (nt:base) IGNORE
{code}

this means:
- having specific OPV flag for all items
- allowing any type of single or multivalued property
- allow any type of child nodes
- not allowing SNS by definition
- mandating node type of child node to be specified (according to the needs of the custom index definition)
- no orderable children

wdyt?



was (Author: anchela):
in this case i would suggest to define oak:queryIndexDefinition as follows:

/**
* Index definitions storage
*
* @since oak 0.6
*/
[oak:QueryIndexDefinition]
  - * (UNDEFINED) IGNORE
  - * (UNDEFINED) multiple IGNORE
  + * (nt:base) IGNORE

this means:
- having specific OPV flag for all items
- allowing any type of single or multivalued property
- allow any type of child nodes
- not allowing SNS by definition
- mandating node type of child node to be specified (according to the needs of the custom index definition)
- no orderable children

wdyt?


> Review node type definition for oak:queryIndexDefinition
> --------------------------------------------------------
>
>                 Key: OAK-1181
>                 URL: https://issues.apache.org/jira/browse/OAK-1181
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>             Fix For: 0.14
>
>
> things to review:
> - name not following naming convention
> - extending from nt:unstructured
> - OPV flags (behavior upon versioning of the parent node)
> - incomplete list of properties compared to those mentioned in query.md
> - 'async' property is string with a predefined value 'async': why not boolean?
> - index content stored underneath the definition has not dedicated node type.
> things to consider:
> - is it expected that an index definition has custom properties?
> - is it expected that such custom properties have other property types that STRING/NAME/BOOLEAN? e.g. a binary?
> - is it expected that an index definition has other child nodes that the index content itself?



--
This message was sent by Atlassian JIRA
(v6.1#6144)