You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/12 09:15:52 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5998: chore: remove unused lagecy codes

wu-sheng commented on a change in pull request #5998:
URL: https://github.com/apache/skywalking/pull/5998#discussion_r541538761



##########
File path: oap-server/server-receiver-plugin/skywalking-mesh-receiver-plugin/src/main/java/org/apache/skywalking/aop/server/receiver/mesh/TelemetryDataDispatcher.java
##########
@@ -103,7 +101,6 @@ public static void process(ServiceMeshMetric.Builder data) {
     static void doDispatch(ServiceMeshMetric.Builder metrics) {
         long minuteTimeBucket = TimeBucket.getMinuteTimeBucket(metrics.getStartTime());
 
-        heartbeat(metrics, minuteTimeBucket);

Review comment:
       Why remove this? If no heartbeat, instances will be gone, and not available on the ui.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org