You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/24 18:44:00 UTC
[GitHub] [flink] sv3ndk opened a new pull request #14743: [doc][hotfix] mentions Maxwell as CDC tool in Kafka connector documentation
sv3ndk opened a new pull request #14743:
URL: https://github.com/apache/flink/pull/14743
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
The current [Kafka connector changelog section of the documentation](https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/connectors/kafka.html#changelog-source) mentions Debezium and Canal CDC tools but not the recently added Maxwell format. This hotifx simply adds such link in the English version of the documentation.
I am not able to update the Chinese documentation, please let me know if I should open a ticket for this or if a small commit could be contributed to this PR.
## Brief change log
- *Add a link to Maxwell format in the changelog section of Kafka connector*
- *Slight rephrasing: now mentioning "CDC changelog" as opposed to simply "changelog" to avoid confusion with the behavior of the upsert Kafka connector*
- *I also took the initiative to remove the last sentence since it only contains links, which are already mentioned in the text just above*
## Verifying this change
Manually executed `./build_docs.sh -p ` for visual check and link validation
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-778294624
Hi @sv3ndk
Thank you for making this change. You may have noticed we recently - two days ago - migrated from Jekyll to Hugo. That means there are some changes in the tags. Instead of link tags please use "ref" as you will find on the rest of the page. There are full instructions on building the Hugo documentation locally on `docs/README.md`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
}, {
"hash" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271",
"triggerID" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1095358d7e5c1982fb362e9b6641cc84a70647c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428)
* f3d0ce7680adcb60b6f31cdc169447d68d2b80f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-778572805
There you go.
By the way, I noticed that the formatting of the maven dependencies is back to the format of a few weeks ago, is this intentional?
In the latest release of the doc, the "maven dependency" column contains an easily copy-able snippet of XML:
https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/connectors/formats/debezium.html
Whereas the same thing in the current master branch shows the artifact id only, as it did in version 1.11 of the doc:
https://ci.apache.org/projects/flink/flink-docs-master/docs/connectors/table/formats/debezium/
I'm the author of those recent XML snippet. If they've been removed intentionally that's fine by me, although maybe that is a regression ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14743: [doc][hotfix] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766411085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
}, {
"hash" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271",
"triggerID" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"triggerType" : "PUSH"
}, {
"hash" : "ddfdd750a01fd31b928217912ecbb4e901304b75",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13306",
"triggerID" : "ddfdd750a01fd31b928217912ecbb4e901304b75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ddfdd750a01fd31b928217912ecbb4e901304b75 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13306)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #14743:
URL: https://github.com/apache/flink/pull/14743#discussion_r575525435
##########
File path: docs/content.zh/docs/connectors/table/kafka.md
##########
@@ -499,12 +499,13 @@ If `timestamp` is specified, another config option `scan.startup.timestamp-milli
If `specific-offsets` is specified, another config option `scan.startup.specific-offsets` is required to specify specific startup offsets for each partition,
e.g. an option value `partition:0,offset:42;partition:1,offset:300` indicates offset `42` for partition `0` and offset `300` for partition `1`.
-### Changelog Source
+### CDC Changelog Source
+
+Flink natively supports Kafka as a CDC changelog source. If messages in Kafka topic is change event captured from other databases using CDC tools, then you can use a CDC format to interpret messages as INSERT/UPDATE/DELETE messages into Flink SQL system.
+
+Flink provides three CDC formats: [debezium-json]({% link dev/table/connectors/formats/debezium.md %}), [canal-json]({% link dev/table/connectors/formats/canal.md %}) and [maxwell-json]({% link dev/table/connectors/formats/maxwell.md %}) to interpret change events captured by [Debezium](https://debezium.io/), [Canal](https://github.com/alibaba/canal/wiki) and [Maxwell](https://maxwells-daemon.io/).
Review comment:
Sounds good to me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766411085
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ddfdd750a01fd31b928217912ecbb4e901304b75 (Fri Feb 19 07:33:40 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-778460353
Hi @sjwiesman,
Got it, thanks for the pointer, I had noticed a change of structure when resolving conflicts, though I'm learning now the doc is based on Hugo.
I'll update links to ref in my next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #14743:
URL: https://github.com/apache/flink/pull/14743#discussion_r575343972
##########
File path: docs/content.zh/docs/connectors/table/kafka.md
##########
@@ -499,12 +499,13 @@ If `timestamp` is specified, another config option `scan.startup.timestamp-milli
If `specific-offsets` is specified, another config option `scan.startup.specific-offsets` is required to specify specific startup offsets for each partition,
e.g. an option value `partition:0,offset:42;partition:1,offset:300` indicates offset `42` for partition `0` and offset `300` for partition `1`.
-### Changelog Source
+### CDC Changelog Source
+
+Flink natively supports Kafka as a CDC changelog source. If messages in Kafka topic is change event captured from other databases using CDC tools, then you can use a CDC format to interpret messages as INSERT/UPDATE/DELETE messages into Flink SQL system.
+
+Flink provides three CDC formats: [debezium-json]({% link dev/table/connectors/formats/debezium.md %}), [canal-json]({% link dev/table/connectors/formats/canal.md %}) and [maxwell-json]({% link dev/table/connectors/formats/maxwell.md %}) to interpret change events captured by [Debezium](https://debezium.io/), [Canal](https://github.com/alibaba/canal/wiki) and [Maxwell](https://maxwells-daemon.io/).
Review comment:
Since this list is getting longer why don't we make it an actual list.
```
Flink provides several CDC formats:
* [debezium-json]()
* [canal-json]()
* others
```
That way its easier to expand this as we add more formats in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [doc][hotfix] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1095358d7e5c1982fb362e9b6641cc84a70647c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [doc][hotfix] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1095358d7e5c1982fb362e9b6641cc84a70647c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #14743:
URL: https://github.com/apache/flink/pull/14743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14743: [doc][hotfix] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766411085
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d1095358d7e5c1982fb362e9b6641cc84a70647c (Sun Jan 24 18:46:06 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-779896145
Thanks, I'm glad you like it.
I'm aware of the formatting. I had issues getting the XML to render properly. I have it as a follow-up to fix before the next release but I didn't want to block the migration on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
}, {
"hash" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271",
"triggerID" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"triggerType" : "PUSH"
}, {
"hash" : "ddfdd750a01fd31b928217912ecbb4e901304b75",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ddfdd750a01fd31b928217912ecbb4e901304b75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f3d0ce7680adcb60b6f31cdc169447d68d2b80f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271)
* ddfdd750a01fd31b928217912ecbb4e901304b75 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14743: [doc][hotfix] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1095358d7e5c1982fb362e9b6641cc84a70647c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-778573015
@sjwiesman by the way, `hugo` is a massive improvement over the previous method. If that's your doing, thanks and congrats!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
}, {
"hash" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1095358d7e5c1982fb362e9b6641cc84a70647c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428)
* f3d0ce7680adcb60b6f31cdc169447d68d2b80f2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
}, {
"hash" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271",
"triggerID" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f3d0ce7680adcb60b6f31cdc169447d68d2b80f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #14743:
URL: https://github.com/apache/flink/pull/14743#discussion_r575520426
##########
File path: docs/content.zh/docs/connectors/table/kafka.md
##########
@@ -499,12 +499,13 @@ If `timestamp` is specified, another config option `scan.startup.timestamp-milli
If `specific-offsets` is specified, another config option `scan.startup.specific-offsets` is required to specify specific startup offsets for each partition,
e.g. an option value `partition:0,offset:42;partition:1,offset:300` indicates offset `42` for partition `0` and offset `300` for partition `1`.
-### Changelog Source
+### CDC Changelog Source
+
+Flink natively supports Kafka as a CDC changelog source. If messages in Kafka topic is change event captured from other databases using CDC tools, then you can use a CDC format to interpret messages as INSERT/UPDATE/DELETE messages into Flink SQL system.
+
+Flink provides three CDC formats: [debezium-json]({% link dev/table/connectors/formats/debezium.md %}), [canal-json]({% link dev/table/connectors/formats/canal.md %}) and [maxwell-json]({% link dev/table/connectors/formats/maxwell.md %}) to interpret change events captured by [Debezium](https://debezium.io/), [Canal](https://github.com/alibaba/canal/wiki) and [Maxwell](https://maxwells-daemon.io/).
Review comment:
Thanks for the feed-back.
How about I make it a list, and I omit the details of the specific flavors of the format, i.e. we choose not to mention here the distinction between `json` and `avro-confluent` and others? That way the user can find all the specific details in the linked pages, and this part of the documentation has less chances of becoming obsolete over time.
Something like this:
```
Flink provides several CDC formats:
* [debezium](...)
* [canal](...)
* [maxwell](...)
```
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14743:
URL: https://github.com/apache/flink/pull/14743#discussion_r575297850
##########
File path: docs/content.zh/docs/connectors/table/kafka.md
##########
@@ -499,12 +499,13 @@ If `timestamp` is specified, another config option `scan.startup.timestamp-milli
If `specific-offsets` is specified, another config option `scan.startup.specific-offsets` is required to specify specific startup offsets for each partition,
e.g. an option value `partition:0,offset:42;partition:1,offset:300` indicates offset `42` for partition `0` and offset `300` for partition `1`.
-### Changelog Source
+### CDC Changelog Source
+
+Flink natively supports Kafka as a CDC changelog source. If messages in Kafka topic is change event captured from other databases using CDC tools, then you can use a CDC format to interpret messages as INSERT/UPDATE/DELETE messages into Flink SQL system.
+
+Flink provides three CDC formats: [debezium-json]({% link dev/table/connectors/formats/debezium.md %}), [canal-json]({% link dev/table/connectors/formats/canal.md %}) and [maxwell-json]({% link dev/table/connectors/formats/maxwell.md %}) to interpret change events captured by [Debezium](https://debezium.io/), [Canal](https://github.com/alibaba/canal/wiki) and [Maxwell](https://maxwells-daemon.io/).
Review comment:
We also support `debezium-avro-confluent` now. The documentation is also located in https://ci.apache.org/projects/flink/flink-docs-master/zh/docs/connectors/table/formats/debezium/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14743: [FLINK-21366][doc] mentions Maxwell as CDC tool in Kafka connector documentation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14743:
URL: https://github.com/apache/flink/pull/14743#issuecomment-766412125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12428",
"triggerID" : "d1095358d7e5c1982fb362e9b6641cc84a70647c",
"triggerType" : "PUSH"
}, {
"hash" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271",
"triggerID" : "f3d0ce7680adcb60b6f31cdc169447d68d2b80f2",
"triggerType" : "PUSH"
}, {
"hash" : "ddfdd750a01fd31b928217912ecbb4e901304b75",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13306",
"triggerID" : "ddfdd750a01fd31b928217912ecbb4e901304b75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f3d0ce7680adcb60b6f31cdc169447d68d2b80f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13271)
* ddfdd750a01fd31b928217912ecbb4e901304b75 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13306)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org