You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2012/11/08 18:14:13 UTC
[jira] [Commented] (HBASE-7128) Reduced annoying catch clauses of
UnsupportedEncodingException that is never thrown because of UTF-8
[ https://issues.apache.org/jira/browse/HBASE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493312#comment-13493312 ]
Ted Yu commented on HBASE-7128:
-------------------------------
In HConstants:
{code}
+ /** When we encode strings, we always specify UTF8 encoding */
+ public static final Charset UTF8_CHARSET = Bytes.UTF8_CHARSET;
{code}
HConstants and Bytes classes are both in hbase-common
Can UTF8_CHARSET be removed from HConstants ?
Patch looks good.
> Reduced annoying catch clauses of UnsupportedEncodingException that is never thrown because of UTF-8
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7128
> URL: https://issues.apache.org/jira/browse/HBASE-7128
> Project: HBase
> Issue Type: Improvement
> Reporter: Hiroshi Ikeda
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-7128.patch
>
>
> There are some codes that catch UnsupportedEncodingException, and log or ignore it because Java always supports UTF-8 (see the javadoc of Charset).
> The catch clauses are annoying, and they should be replaced by methods of Bytes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira