You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/03 16:37:18 UTC
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #894: MINIFICPP-1351 fix PublishKafka::notifyStop race condition over connection
szaszm opened a new pull request #894:
URL: https://github.com/apache/nifi-minifi-cpp/pull/894
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #894: MINIFICPP-1351 fix PublishKafka::notifyStop race condition over connection
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #894:
URL: https://github.com/apache/nifi-minifi-cpp/pull/894#discussion_r483114073
##########
File path: extensions/librdkafka/PublishKafka.h
##########
@@ -125,7 +125,7 @@ class PublishKafka : public core::Processor {
utils::Regex attributeNameRegex_;
std::atomic<bool> interrupted_{false};
- std::mutex messages_mutex_;
+ std::mutex messages_mutex_; // If both connection_mutex_ and messages_mutex_ are needed, always take connection_mutex_ first to avoid deadlock
Review comment:
Letting others learn from my mistakes :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #894: MINIFICPP-1351 fix PublishKafka::notifyStop race condition over connection
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #894:
URL: https://github.com/apache/nifi-minifi-cpp/pull/894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #894: MINIFICPP-1351 fix PublishKafka::notifyStop race condition over connection
Posted by GitBox <gi...@apache.org>.
szaszm edited a comment on pull request #894:
URL: https://github.com/apache/nifi-minifi-cpp/pull/894#issuecomment-686653962
CI Failures:
- ListenHTTP on mac: maybe unstable, but definitely not related
- FileUtilsTests on ubuntu 20.04: ~1 millisecond time travel, probably instruction reordering or something IO, not related
- GetTCP TLS on ubuntu 16.04-all: looks like maybe a deadlock, not related
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #894: MINIFICPP-1351 fix PublishKafka::notifyStop race condition over connection
Posted by GitBox <gi...@apache.org>.
arpadboda commented on a change in pull request #894:
URL: https://github.com/apache/nifi-minifi-cpp/pull/894#discussion_r483113299
##########
File path: extensions/librdkafka/PublishKafka.h
##########
@@ -125,7 +125,7 @@ class PublishKafka : public core::Processor {
utils::Regex attributeNameRegex_;
std::atomic<bool> interrupted_{false};
- std::mutex messages_mutex_;
+ std::mutex messages_mutex_; // If both connection_mutex_ and messages_mutex_ are needed, always take connection_mutex_ first to avoid deadlock
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #894: MINIFICPP-1351 fix PublishKafka::notifyStop race condition over connection
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #894:
URL: https://github.com/apache/nifi-minifi-cpp/pull/894#issuecomment-686653962
Failures:
- ListenHTTP on mac: maybe unstable, but definitely not related
- FileUtilsTests on ubuntu 20.04: ~1 millisecond time travel, probably instruction reordering or something IO, not related
- GetTCP TLS: looks like maybe a deadlock, not related
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org