You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/31 01:46:37 UTC

[GitHub] [spark] viirya opened a new pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

viirya opened a new pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   This patch proposed to add python dependencies even it is not Python applications.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   For now, we add `pyFiles` argument to `files` argument only for Python applications, in SparkSubmit. Like the reason in #21420, "for some Spark applications, though they're a java program, they require not only jar dependencies, but also python dependencies.", we need to add `pyFiles` to `files` even it is not Python applications.
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   Yes. After this change, for non-PySpark applications, the Python files specified by `pyFiles` are also added to `files` like PySpark applications.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Manually test on jupyter notebook.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606350316
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#discussion_r400661739
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -474,10 +474,12 @@ private[spark] class SparkSubmit extends Logging {
         args.mainClass = "org.apache.spark.deploy.PythonRunner"
         args.childArgs = ArrayBuffer(localPrimaryResource, localPyFiles) ++ args.childArgs
       }
-      if (clusterManager != YARN) {
-        // The YARN backend handles python files differently, so don't merge the lists.
-        args.files = mergeFileLists(args.files, args.pyFiles)
-      }
+    }
+
+    // Non-PySpark applications will also need Python dependencies.
+    if (deployMode == CLIENT && clusterManager != YARN) {
 
 Review comment:
   Got it. Thanks, @viirya .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606398594
 
 
   **[Test build #120628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120628/testReport)** for PR 28077 at commit [`8b5edef`](https://github.com/apache/spark/commit/8b5edefe2ba6c4ab04a00ccb865247e93794ea4c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606391003
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606350321
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25324/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606440981
 
 
   **[Test build #120628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120628/testReport)** for PR 28077 at commit [`8b5edef`](https://github.com/apache/spark/commit/8b5edefe2ba6c4ab04a00ccb865247e93794ea4c).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606441452
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120628/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606452651
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25333/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606968038
 
 
   Merged to master. Thank you, @viirya and @HyukjinKwon .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] viirya commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
viirya commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606449060
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606399024
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25330/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606391005
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120622/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606452646
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] viirya commented on a change in pull request #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#discussion_r400650242
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -474,10 +474,12 @@ private[spark] class SparkSubmit extends Logging {
         args.mainClass = "org.apache.spark.deploy.PythonRunner"
         args.childArgs = ArrayBuffer(localPrimaryResource, localPyFiles) ++ args.childArgs
       }
-      if (clusterManager != YARN) {
-        // The YARN backend handles python files differently, so don't merge the lists.
-        args.files = mergeFileLists(args.files, args.pyFiles)
-      }
+    }
+
+    // Non-PySpark applications will also need Python dependencies.
+    if (deployMode == CLIENT && clusterManager != YARN) {
 
 Review comment:
   No, I don't see we merge it for cluster deploy mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606391003
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606349919
 
 
   **[Test build #120622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120622/testReport)** for PR 28077 at commit [`a892907`](https://github.com/apache/spark/commit/a892907b8216a9c0934cf1cc570ddaebe707f992).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606399024
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25330/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606350316
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606537899
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606349919
 
 
   **[Test build #120622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120622/testReport)** for PR 28077 at commit [`a892907`](https://github.com/apache/spark/commit/a892907b8216a9c0934cf1cc570ddaebe707f992).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606441452
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120628/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606441440
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606399021
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#discussion_r400615348
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -474,10 +474,12 @@ private[spark] class SparkSubmit extends Logging {
         args.mainClass = "org.apache.spark.deploy.PythonRunner"
         args.childArgs = ArrayBuffer(localPrimaryResource, localPyFiles) ++ args.childArgs
       }
-      if (clusterManager != YARN) {
-        // The YARN backend handles python files differently, so don't merge the lists.
-        args.files = mergeFileLists(args.files, args.pyFiles)
-      }
+    }
+
+    // Non-PySpark applications will also need Python dependencies.
 
 Review comment:
   nit: `will also` -> `can`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606536597
 
 
   **[Test build #120631 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120631/testReport)** for PR 28077 at commit [`8b5edef`](https://github.com/apache/spark/commit/8b5edefe2ba6c4ab04a00ccb865247e93794ea4c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606452118
 
 
   **[Test build #120631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120631/testReport)** for PR 28077 at commit [`8b5edef`](https://github.com/apache/spark/commit/8b5edefe2ba6c4ab04a00ccb865247e93794ea4c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606388764
 
 
   Hi, @viirya . This PR title looks too broad. Could you be more specific by excluding the scope of SPARK-24377 ?
   > [SPARK-24377][Spark Submit] make --py-files work in non pyspark application

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606452646
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606350321
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25324/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606398594
 
 
   **[Test build #120628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120628/testReport)** for PR 28077 at commit [`8b5edef`](https://github.com/apache/spark/commit/8b5edefe2ba6c4ab04a00ccb865247e93794ea4c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606452118
 
 
   **[Test build #120631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120631/testReport)** for PR 28077 at commit [`8b5edef`](https://github.com/apache/spark/commit/8b5edefe2ba6c4ab04a00ccb865247e93794ea4c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606537899
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606537910
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120631/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606373680
 
 
   I think it's fine. cc @vanzin and @jerryshao 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606391005
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120622/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606537910
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120631/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606390509
 
 
   **[Test build #120622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120622/testReport)** for PR 28077 at commit [`a892907`](https://github.com/apache/spark/commit/a892907b8216a9c0934cf1cc570ddaebe707f992).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] viirya commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
viirya commented on issue #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606354677
 
 
   Maybe we need a unit test too. But let me wait for some comments first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] viirya commented on a change in pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#discussion_r400641643
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -474,10 +474,12 @@ private[spark] class SparkSubmit extends Logging {
         args.mainClass = "org.apache.spark.deploy.PythonRunner"
         args.childArgs = ArrayBuffer(localPrimaryResource, localPyFiles) ++ args.childArgs
       }
-      if (clusterManager != YARN) {
-        // The YARN backend handles python files differently, so don't merge the lists.
-        args.files = mergeFileLists(args.files, args.pyFiles)
-      }
+    }
+
+    // Non-PySpark applications will also need Python dependencies.
 
 Review comment:
   fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606441440
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606399021
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28077: [SPARK-31308][PySpark] Merging pyFiles to files argument for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#issuecomment-606452651
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25333/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28077: [SPARK-31308][PySpark] Make Python dependencies available for Non-PySpark applications
URL: https://github.com/apache/spark/pull/28077#discussion_r400634191
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -474,10 +474,12 @@ private[spark] class SparkSubmit extends Logging {
         args.mainClass = "org.apache.spark.deploy.PythonRunner"
         args.childArgs = ArrayBuffer(localPrimaryResource, localPyFiles) ++ args.childArgs
       }
-      if (clusterManager != YARN) {
-        // The YARN backend handles python files differently, so don't merge the lists.
-        args.files = mergeFileLists(args.files, args.pyFiles)
-      }
+    }
+
+    // Non-PySpark applications will also need Python dependencies.
+    if (deployMode == CLIENT && clusterManager != YARN) {
 
 Review comment:
   Just a question. Did we `mergeFileLists` for `deployMode != CLIENT` already?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org