You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/02 15:03:30 UTC

[GitHub] [beam] mxm commented on a change in pull request #12759: [BEAM-10760] Generalize state cleanup optimization for global window

mxm commented on a change in pull request #12759:
URL: https://github.com/apache/beam/pull/12759#discussion_r482141442



##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -1330,6 +1338,19 @@ public void setTimer(
     @Deprecated
     @Override
     public void setTimer(TimerData timer) {
+      if (timer.getTimestamp().isAfter(GlobalWindow.INSTANCE.maxTimestamp())) {

Review comment:
       It was a deliberate decision not to do it using CleanupTimer. Setting the timer is an implementation detail and should be transparent to the CleanupTimer class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org