You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Vincent Massol <vi...@massol.net> on 2007/03/16 15:45:55 UTC

[VOTE] Release Clover plugin v2.4

Hi,

As Mike Perham pointed out the Clover license for the release clover  
plugin (ie v2.3) has expired. Thus the urgency to release version 2.4.

Here's the release notes for 2.4:

** Bug
     * [MCLOVER-45] - Excluded files should be added to compiled sources
     * [MCLOVER-53] - Clover plugin installs clover instrumented  
source in local repository

** Improvement
     * [MCLOVER-38] - Allow check Mojo to be overriden by a  
failOnViolation parameter in the same way PMD and Checkstyle can
     * [MCLOVER-65] - Clover license has expired

Here's my +1

Thanks
-Vincent

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Emmanuel Venisse <em...@venisse.net>.
+1

Emmanuel

Vincent Massol a écrit :
> Hi,
> 
> As Mike Perham pointed out the Clover license for the release clover 
> plugin (ie v2.3) has expired. Thus the urgency to release version 2.4.
> 
> Here's the release notes for 2.4:
> 
> ** Bug
>     * [MCLOVER-45] - Excluded files should be added to compiled sources
>     * [MCLOVER-53] - Clover plugin installs clover instrumented source 
> in local repository
> 
> ** Improvement
>     * [MCLOVER-38] - Allow check Mojo to be overriden by a 
> failOnViolation parameter in the same way PMD and Checkstyle can
>     * [MCLOVER-65] - Clover license has expired
> 
> Here's my +1
> 
> Thanks
> -Vincent
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Mike Perham <mp...@gmail.com>.
+1

On 3/16/07, Vincent Massol <vi...@massol.net> wrote:
> Hi,
>
> As Mike Perham pointed out the Clover license for the release clover
> plugin (ie v2.3) has expired. Thus the urgency to release version 2.4.
>
> Here's the release notes for 2.4:
>
> ** Bug
>      * [MCLOVER-45] - Excluded files should be added to compiled sources
>      * [MCLOVER-53] - Clover plugin installs clover instrumented
> source in local repository
>
> ** Improvement
>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
> failOnViolation parameter in the same way PMD and Checkstyle can
>      * [MCLOVER-65] - Clover license has expired
>
> Here's my +1
>
> Thanks
> -Vincent
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Vincent Siveton <vi...@gmail.com>.
my late +1

Vincent

2007/3/16, Vincent Massol <vi...@massol.net>:
> Hi,
>
> As Mike Perham pointed out the Clover license for the release clover
> plugin (ie v2.3) has expired. Thus the urgency to release version 2.4.
>
> Here's the release notes for 2.4:
>
> ** Bug
>      * [MCLOVER-45] - Excluded files should be added to compiled sources
>      * [MCLOVER-53] - Clover plugin installs clover instrumented
> source in local repository
>
> ** Improvement
>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
> failOnViolation parameter in the same way PMD and Checkstyle can
>      * [MCLOVER-65] - Clover license has expired
>
> Here's my +1
>
> Thanks
> -Vincent
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Jason van Zyl <ja...@maven.org>.
+1

Jason.

On 16 Mar 07, at 10:45 AM 16 Mar 07, Vincent Massol wrote:

> Hi,
>
> As Mike Perham pointed out the Clover license for the release  
> clover plugin (ie v2.3) has expired. Thus the urgency to release  
> version 2.4.
>
> Here's the release notes for 2.4:
>
> ** Bug
>     * [MCLOVER-45] - Excluded files should be added to compiled  
> sources
>     * [MCLOVER-53] - Clover plugin installs clover instrumented  
> source in local repository
>
> ** Improvement
>     * [MCLOVER-38] - Allow check Mojo to be overriden by a  
> failOnViolation parameter in the same way PMD and Checkstyle can
>     * [MCLOVER-65] - Clover license has expired
>
> Here's my +1
>
> Thanks
> -Vincent
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Vincent Massol <vi...@massol.net>.
On Apr 9, 2007, at 5:27 PM, Gregory Kick wrote:

> Whatever happened with this?

I wanted to do it when I started the vote because I had a few hours  
free and then I was told there's a new dev process for releasing  
stuff and I haven't had the time since then to figure out how to use  
that new process. I'm still planning to release the clover plugin  
ASAP, just don't have much time in a row.

If someone could guide me on IRC on how to do releases now that would  
be great.

Thanks
-Vincent

> On 3/26/07, Daniel Kulp <dk...@apache.org> wrote:
>> On Sunday 25 March 2007 13:30, Vincent Massol wrote:
>> > I've tried to write several different integration tests to test  
>> this
>> > but it's always working...
>> >
>> > There are a lot of issues with the Clover plugin but that's only on
>> > Maven 2.1 and that's because Maven 2.1 is doing things very
>> > differently and I believe has broken the Clover plugin.
>> >
>> > I tested it with 2.0.5 and everything works fine for me.
>> >
>> > Let me know if you have any idea. If not, I'll consider that it's
>> > working fine... :)
>>
>> Strange.   Oh well.   If it has a test that works fine, go for it.
>>
>> +1
>>
>> Dan
>>
>>
>> >
>> > Thanks
>> > -Vincent
>> >
>> > >>> 2) You didn't provide a staging location and such for the vote.
>> > >>
>> > >> What kind of staging location? Is it simply a matter of  
>> putting the
>> > >> plugin jar somewhere or do I need to reproduce a maven repo
>> > >> structure and such (and if so how)? I probably missed the
>> > >> discussions on this and I apologize for that.
>> > >
>> > > Jason documented most of it at:
>> > > http://maven.apache.org/developers/release/releasing.html
>> > >
>> > > Dan
>> > >
>> > >> Thanks
>> > >> -Vincent
>> > >>
>> > >>> On Friday 16 March 2007 10:45, Vincent Massol wrote:
>> > >>>> Hi,
>> > >>>>
>> > >>>> As Mike Perham pointed out the Clover license for the release
>> > >>>> clover plugin (ie v2.3) has expired. Thus the urgency to  
>> release
>> > >>>> version 2.4.
>> > >>>>
>> > >>>> Here's the release notes for 2.4:
>> > >>>>
>> > >>>> ** Bug
>> > >>>>      * [MCLOVER-45] - Excluded files should be added to  
>> compiled
>> > >>>> sources * [MCLOVER-53] - Clover plugin installs clover
>> > >>>> instrumented source in local repository
>> > >>>>
>> > >>>> ** Improvement
>> > >>>>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
>> > >>>> failOnViolation parameter in the same way PMD and  
>> Checkstyle can
>> > >>>>      * [MCLOVER-65] - Clover license has expired
>> > >>>>
>> > >>>> Here's my +1
>> > >>>>
>> > >>>> Thanks
>> > >>>> -Vincent
>> > >>>>
>> > >>>>  
>> -----------------------------------------------------------------
>> > >>>>-- -- To unsubscribe, e-mail: dev- 
>> unsubscribe@maven.apache.org For
>> > >>>> additional commands, e-mail: dev-help@maven.apache.org
>> > >>>
>> > >>> --
>> > >>> J. Daniel Kulp
>> > >>> Principal Engineer
>> > >>> IONA
>> > >>> P: 781-902-8727    C: 508-380-7194
>> > >>> daniel.kulp@iona.com
>> > >>> http://www.dankulp.com/blog
>> > >>>
>> > >>>  
>> ------------------------------------------------------------------
>> > >>>-- - To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org  
>> For
>> > >>> additional commands, e-mail: dev-help@maven.apache.org
>> > >>
>> > >>  
>> -------------------------------------------------------------------
>> > >>-- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > >> For additional commands, e-mail: dev-help@maven.apache.org
>> > >
>> > > --
>> > > J. Daniel Kulp
>> > > Principal Engineer
>> > > IONA
>> > > P: 781-902-8727    C: 508-380-7194
>> > > daniel.kulp@iona.com
>> > > http://www.dankulp.com/blog
>> > >
>> > >  
>> --------------------------------------------------------------------
>> > >- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > For additional commands, e-mail: dev-help@maven.apache.org
>> >
>> >  
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>>
>> --
>> J. Daniel Kulp
>> Principal Engineer
>> IONA
>> P: 781-902-8727    C: 508-380-7194
>> daniel.kulp@iona.com
>> http://www.dankulp.com/blog
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
> -- 
> Gregory Kick
> http://kickstyle.net/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Gregory Kick <gk...@gmail.com>.
Whatever happened with this?

On 3/26/07, Daniel Kulp <dk...@apache.org> wrote:
> On Sunday 25 March 2007 13:30, Vincent Massol wrote:
> > I've tried to write several different integration tests to test this
> > but it's always working...
> >
> > There are a lot of issues with the Clover plugin but that's only on
> > Maven 2.1 and that's because Maven 2.1 is doing things very
> > differently and I believe has broken the Clover plugin.
> >
> > I tested it with 2.0.5 and everything works fine for me.
> >
> > Let me know if you have any idea. If not, I'll consider that it's
> > working fine... :)
>
> Strange.   Oh well.   If it has a test that works fine, go for it.
>
> +1
>
> Dan
>
>
> >
> > Thanks
> > -Vincent
> >
> > >>> 2) You didn't provide a staging location and such for the vote.
> > >>
> > >> What kind of staging location? Is it simply a matter of putting the
> > >> plugin jar somewhere or do I need to reproduce a maven repo
> > >> structure and such (and if so how)? I probably missed the
> > >> discussions on this and I apologize for that.
> > >
> > > Jason documented most of it at:
> > > http://maven.apache.org/developers/release/releasing.html
> > >
> > > Dan
> > >
> > >> Thanks
> > >> -Vincent
> > >>
> > >>> On Friday 16 March 2007 10:45, Vincent Massol wrote:
> > >>>> Hi,
> > >>>>
> > >>>> As Mike Perham pointed out the Clover license for the release
> > >>>> clover plugin (ie v2.3) has expired. Thus the urgency to release
> > >>>> version 2.4.
> > >>>>
> > >>>> Here's the release notes for 2.4:
> > >>>>
> > >>>> ** Bug
> > >>>>      * [MCLOVER-45] - Excluded files should be added to compiled
> > >>>> sources * [MCLOVER-53] - Clover plugin installs clover
> > >>>> instrumented source in local repository
> > >>>>
> > >>>> ** Improvement
> > >>>>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
> > >>>> failOnViolation parameter in the same way PMD and Checkstyle can
> > >>>>      * [MCLOVER-65] - Clover license has expired
> > >>>>
> > >>>> Here's my +1
> > >>>>
> > >>>> Thanks
> > >>>> -Vincent
> > >>>>
> > >>>> -----------------------------------------------------------------
> > >>>>-- -- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > >>>> additional commands, e-mail: dev-help@maven.apache.org
> > >>>
> > >>> --
> > >>> J. Daniel Kulp
> > >>> Principal Engineer
> > >>> IONA
> > >>> P: 781-902-8727    C: 508-380-7194
> > >>> daniel.kulp@iona.com
> > >>> http://www.dankulp.com/blog
> > >>>
> > >>> ------------------------------------------------------------------
> > >>>-- - To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > >>> additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >> -------------------------------------------------------------------
> > >>-- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >> For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > > --
> > > J. Daniel Kulp
> > > Principal Engineer
> > > IONA
> > > P: 781-902-8727    C: 508-380-7194
> > > daniel.kulp@iona.com
> > > http://www.dankulp.com/blog
> > >
> > > --------------------------------------------------------------------
> > >- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> --
> J. Daniel Kulp
> Principal Engineer
> IONA
> P: 781-902-8727    C: 508-380-7194
> daniel.kulp@iona.com
> http://www.dankulp.com/blog
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
Gregory Kick
http://kickstyle.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Daniel Kulp <dk...@apache.org>.
On Sunday 25 March 2007 13:30, Vincent Massol wrote:
> I've tried to write several different integration tests to test this
> but it's always working...
>
> There are a lot of issues with the Clover plugin but that's only on
> Maven 2.1 and that's because Maven 2.1 is doing things very
> differently and I believe has broken the Clover plugin.
>
> I tested it with 2.0.5 and everything works fine for me.
>
> Let me know if you have any idea. If not, I'll consider that it's
> working fine... :)

Strange.   Oh well.   If it has a test that works fine, go for it.   

+1

Dan


>
> Thanks
> -Vincent
>
> >>> 2) You didn't provide a staging location and such for the vote.
> >>
> >> What kind of staging location? Is it simply a matter of putting the
> >> plugin jar somewhere or do I need to reproduce a maven repo
> >> structure and such (and if so how)? I probably missed the
> >> discussions on this and I apologize for that.
> >
> > Jason documented most of it at:
> > http://maven.apache.org/developers/release/releasing.html
> >
> > Dan
> >
> >> Thanks
> >> -Vincent
> >>
> >>> On Friday 16 March 2007 10:45, Vincent Massol wrote:
> >>>> Hi,
> >>>>
> >>>> As Mike Perham pointed out the Clover license for the release
> >>>> clover plugin (ie v2.3) has expired. Thus the urgency to release
> >>>> version 2.4.
> >>>>
> >>>> Here's the release notes for 2.4:
> >>>>
> >>>> ** Bug
> >>>>      * [MCLOVER-45] - Excluded files should be added to compiled
> >>>> sources * [MCLOVER-53] - Clover plugin installs clover
> >>>> instrumented source in local repository
> >>>>
> >>>> ** Improvement
> >>>>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
> >>>> failOnViolation parameter in the same way PMD and Checkstyle can
> >>>>      * [MCLOVER-65] - Clover license has expired
> >>>>
> >>>> Here's my +1
> >>>>
> >>>> Thanks
> >>>> -Vincent
> >>>>
> >>>> -----------------------------------------------------------------
> >>>>-- -- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> >>>> additional commands, e-mail: dev-help@maven.apache.org
> >>>
> >>> --
> >>> J. Daniel Kulp
> >>> Principal Engineer
> >>> IONA
> >>> P: 781-902-8727    C: 508-380-7194
> >>> daniel.kulp@iona.com
> >>> http://www.dankulp.com/blog
> >>>
> >>> ------------------------------------------------------------------
> >>>-- - To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> >>> additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> -------------------------------------------------------------------
> >>-- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > --
> > J. Daniel Kulp
> > Principal Engineer
> > IONA
> > P: 781-902-8727    C: 508-380-7194
> > daniel.kulp@iona.com
> > http://www.dankulp.com/blog
> >
> > --------------------------------------------------------------------
> >- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Vincent Massol <vi...@massol.net>.
Daniel,

On Mar 22, 2007, at 9:58 PM, Daniel Kulp wrote:

>
> Vincent,
>
> On Thursday 22 March 2007 16:30, Vincent Massol wrote:
>> Can you tell me more about it?
>>
>> I've checked and I've noticed you add the following 3 lines to
>> PmdReport.java:
>>
>> +        locator.addSearchPath( FileResourceLoader.ID,  
>> project.getFile
>> ().getParentFile().getAbsolutePath() );
>> +        locator.addSearchPath( "url", "" );
>> +        locator.setOutputDirectory( new File( project.getBuild
>> ().getDirectory() ) );
>>
>> What is the current if you don't have these lines (I need to
>> understand so that I can add a test for the problem - Note that I
>> already have a test for bundling a Clover license file in a JAR and
>> it seems to work fine)?
>
> The problem usually would be if the Clover license is from a non- 
> jar URL.
> The unit test I did for PMD was to throw it on the filesystem and  
> create
> a "file:/" URL for it.  However, it's possibly broken for any URL  
> (like
> HTTP).

I've tried to write several different integration tests to test this  
but it's always working...

There are a lot of issues with the Clover plugin but that's only on  
Maven 2.1 and that's because Maven 2.1 is doing things very  
differently and I believe has broken the Clover plugin.

I tested it with 2.0.5 and everything works fine for me.

Let me know if you have any idea. If not, I'll consider that it's  
working fine... :)

Thanks
-Vincent

>>> 2) You didn't provide a staging location and such for the vote.
>> What kind of staging location? Is it simply a matter of putting the
>> plugin jar somewhere or do I need to reproduce a maven repo structure
>> and such (and if so how)? I probably missed the discussions on this
>> and I apologize for that.
>
> Jason documented most of it at:
> http://maven.apache.org/developers/release/releasing.html
>
> Dan
>
>
>>
>> Thanks
>> -Vincent
>>
>>> On Friday 16 March 2007 10:45, Vincent Massol wrote:
>>>> Hi,
>>>>
>>>> As Mike Perham pointed out the Clover license for the release
>>>> clover plugin (ie v2.3) has expired. Thus the urgency to release
>>>> version 2.4.
>>>>
>>>> Here's the release notes for 2.4:
>>>>
>>>> ** Bug
>>>>      * [MCLOVER-45] - Excluded files should be added to compiled
>>>> sources * [MCLOVER-53] - Clover plugin installs clover instrumented
>>>> source in local repository
>>>>
>>>> ** Improvement
>>>>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
>>>> failOnViolation parameter in the same way PMD and Checkstyle can
>>>>      * [MCLOVER-65] - Clover license has expired
>>>>
>>>> Here's my +1
>>>>
>>>> Thanks
>>>> -Vincent
>>>>
>>>> -------------------------------------------------------------------
>>>> -- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> --
>>> J. Daniel Kulp
>>> Principal Engineer
>>> IONA
>>> P: 781-902-8727    C: 508-380-7194
>>> daniel.kulp@iona.com
>>> http://www.dankulp.com/blog
>>>
>>> --------------------------------------------------------------------
>>> - To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> -- 
> J. Daniel Kulp
> Principal Engineer
> IONA
> P: 781-902-8727    C: 508-380-7194
> daniel.kulp@iona.com
> http://www.dankulp.com/blog
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Daniel Kulp <dk...@apache.org>.
Vincent,

On Thursday 22 March 2007 16:30, Vincent Massol wrote:
> Can you tell me more about it?
>
> I've checked and I've noticed you add the following 3 lines to
> PmdReport.java:
>
> +        locator.addSearchPath( FileResourceLoader.ID, project.getFile
> ().getParentFile().getAbsolutePath() );
> +        locator.addSearchPath( "url", "" );
> +        locator.setOutputDirectory( new File( project.getBuild
> ().getDirectory() ) );
>
> What is the current if you don't have these lines (I need to
> understand so that I can add a test for the problem - Note that I
> already have a test for bundling a Clover license file in a JAR and
> it seems to work fine)?

The problem usually would be if the Clover license is from a non-jar URL.   
The unit test I did for PMD was to throw it on the filesystem and create 
a "file:/" URL for it.  However, it's possibly broken for any URL (like 
HTTP).


> > 2) You didn't provide a staging location and such for the vote.
> What kind of staging location? Is it simply a matter of putting the
> plugin jar somewhere or do I need to reproduce a maven repo structure
> and such (and if so how)? I probably missed the discussions on this
> and I apologize for that.

Jason documented most of it at:
http://maven.apache.org/developers/release/releasing.html

Dan


>
> Thanks
> -Vincent
>
> > On Friday 16 March 2007 10:45, Vincent Massol wrote:
> >> Hi,
> >>
> >> As Mike Perham pointed out the Clover license for the release
> >> clover plugin (ie v2.3) has expired. Thus the urgency to release
> >> version 2.4.
> >>
> >> Here's the release notes for 2.4:
> >>
> >> ** Bug
> >>      * [MCLOVER-45] - Excluded files should be added to compiled
> >> sources * [MCLOVER-53] - Clover plugin installs clover instrumented
> >> source in local repository
> >>
> >> ** Improvement
> >>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
> >> failOnViolation parameter in the same way PMD and Checkstyle can
> >>      * [MCLOVER-65] - Clover license has expired
> >>
> >> Here's my +1
> >>
> >> Thanks
> >> -Vincent
> >>
> >> -------------------------------------------------------------------
> >>-- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > --
> > J. Daniel Kulp
> > Principal Engineer
> > IONA
> > P: 781-902-8727    C: 508-380-7194
> > daniel.kulp@iona.com
> > http://www.dankulp.com/blog
> >
> > --------------------------------------------------------------------
> >- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Vincent Massol <vi...@massol.net>.
Hi Daniel,

On Mar 16, 2007, at 4:26 PM, Daniel Kulp wrote:

>
> Vincent,
>
> Two issues:
>
> 1)  I notice trunk of clover uses the ResourceManager.   Thus, it
> probably suffers from the same problem as PMD and Checkstyle.   Thus,
> the license location is probably not able to be a URL like the docs  
> say
> and would thus be a regression from 2.3.

Can you tell me more about it?

I've checked and I've noticed you add the following 3 lines to  
PmdReport.java:

+        locator.addSearchPath( FileResourceLoader.ID, project.getFile 
().getParentFile().getAbsolutePath() );
+        locator.addSearchPath( "url", "" );
+        locator.setOutputDirectory( new File( project.getBuild 
().getDirectory() ) );

What is the current if you don't have these lines (I need to  
understand so that I can add a test for the problem - Note that I  
already have a test for bundling a Clover license file in a JAR and  
it seems to work fine)?

>
> 2) You didn't provide a staging location and such for the vote.

What kind of staging location? Is it simply a matter of putting the  
plugin jar somewhere or do I need to reproduce a maven repo structure  
and such (and if so how)? I probably missed the discussions on this  
and I apologize for that.

Thanks
-Vincent

> On Friday 16 March 2007 10:45, Vincent Massol wrote:
>> Hi,
>>
>> As Mike Perham pointed out the Clover license for the release clover
>> plugin (ie v2.3) has expired. Thus the urgency to release version  
>> 2.4.
>>
>> Here's the release notes for 2.4:
>>
>> ** Bug
>>      * [MCLOVER-45] - Excluded files should be added to compiled
>> sources * [MCLOVER-53] - Clover plugin installs clover instrumented
>> source in local repository
>>
>> ** Improvement
>>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
>> failOnViolation parameter in the same way PMD and Checkstyle can
>>      * [MCLOVER-65] - Clover license has expired
>>
>> Here's my +1
>>
>> Thanks
>> -Vincent
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> -- 
> J. Daniel Kulp
> Principal Engineer
> IONA
> P: 781-902-8727    C: 508-380-7194
> daniel.kulp@iona.com
> http://www.dankulp.com/blog
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [VOTE] Release Clover plugin v2.4

Posted by Daniel Kulp <da...@iona.com>.
Vincent,

Two issues:

1)  I notice trunk of clover uses the ResourceManager.   Thus, it 
probably suffers from the same problem as PMD and Checkstyle.   Thus, 
the license location is probably not able to be a URL like the docs say 
and would thus be a regression from 2.3.  

2) You didn't provide a staging location and such for the vote.  

Dan

On Friday 16 March 2007 10:45, Vincent Massol wrote:
> Hi,
>
> As Mike Perham pointed out the Clover license for the release clover
> plugin (ie v2.3) has expired. Thus the urgency to release version 2.4.
>
> Here's the release notes for 2.4:
>
> ** Bug
>      * [MCLOVER-45] - Excluded files should be added to compiled
> sources * [MCLOVER-53] - Clover plugin installs clover instrumented
> source in local repository
>
> ** Improvement
>      * [MCLOVER-38] - Allow check Mojo to be overriden by a
> failOnViolation parameter in the same way PMD and Checkstyle can
>      * [MCLOVER-65] - Clover license has expired
>
> Here's my +1
>
> Thanks
> -Vincent
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org