You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/09/15 15:28:23 UTC

[kudu-CR] [java] Fix shading of Micrometer dependency 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16452


Change subject: [java] Fix shading of Micrometer dependency
......................................................................

[java] Fix shading of Micrometer dependency

This patch adjusts the Java build to ensure Micrometer classes
and it’s dependencies are relocated properly. It also adjusts
verify_jars.pl to account for the change.

Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
---
M build-support/verify_jars.pl
M java/gradle/shadow.gradle
2 files changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/16452/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 18:35:19 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 18:34:18 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16452/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16452/1//COMMIT_MSG@10
PS1, Line 10: it’s
> its
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 18:18:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 18:50:18 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16452/1/build-support/verify_jars.pl
File build-support/verify_jars.pl:

http://gerrit.cloudera.org:8080/#/c/16452/1/build-support/verify_jars.pl@37
PS1, Line 37: my $pat_allow_kudu_shaded =
> Why doesn't this have to include everything in shadow.gradle? E.g. no hamcr
It doesn't look like we actually shade hamcrest anymore. I will remove it in a follow on commit.



-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 17:45:10 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................

[java] Fix shading of Micrometer dependency

This patch adjusts the Java build to ensure Micrometer classes
and its dependencies are relocated properly. It also adjusts
verify_jars.pl to account for the change.

Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Reviewed-on: http://gerrit.cloudera.org:8080/16452
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M build-support/verify_jars.pl
M java/gradle/shadow.gradle
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Grant Henke: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16452/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16452/1//COMMIT_MSG@10
PS1, Line 10: it’s
its



-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 18:06:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16452 )

Change subject: [java] Fix shading of Micrometer dependency
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16452/1/build-support/verify_jars.pl
File build-support/verify_jars.pl:

http://gerrit.cloudera.org:8080/#/c/16452/1/build-support/verify_jars.pl@37
PS1, Line 37: my $pat_allow_kudu_shaded =
Why doesn't this have to include everything in shadow.gradle? E.g. no hamcrest



-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2020 17:36:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix shading of Micrometer dependency

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16452

to look at the new patch set (#2).

Change subject: [java] Fix shading of Micrometer dependency
......................................................................

[java] Fix shading of Micrometer dependency

This patch adjusts the Java build to ensure Micrometer classes
and its dependencies are relocated properly. It also adjusts
verify_jars.pl to account for the change.

Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
---
M build-support/verify_jars.pl
M java/gradle/shadow.gradle
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/16452/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2547b5703e5d300de531aa51d55f37718a27b61
Gerrit-Change-Number: 16452
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)