[jira] [Commented] (REEF-1150) Use `static` members properly by removing access by `instance` reference

["Mariia Mykhailova (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115828#comment-15115828 ] 

Mariia Mykhailova commented on REEF-1150:
-----------------------------------------

Is there a way to detect such cases automatically?

> Use `static` members properly by removing access by `instance` reference
> ------------------------------------------------------------------------
>
>                 Key: REEF-1150
>                 URL: https://issues.apache.org/jira/browse/REEF-1150
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF Bridge, REEF-Common, REEF-IO, Tang
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>
> `static` members (methods and variables) should not be accessed by using `instance` reference. This issue fixes the followings.
> {code:title=JobClient.java|borderStyle=solid}
> -        this.driverConfiguration = Configurations.merge(this.driverConfiguration, this.getYarnConfiguration());
> +        this.driverConfiguration = Configurations.merge(this.driverConfiguration, JobClient.getYarnConfiguration());
> {code}
> {code:title=LoggingScopeFactory.java|borderStyle=solid}
> -    return new LoggingScopeImpl(LOG, logLevel, this.DRIVER_STOP + " :" + timeStamp);
> +    return new LoggingScopeImpl(LOG, logLevel, DRIVER_STOP + " :" + timeStamp);
> {code}
> {code:title=AvroConfigurationSerializer.java|borderStyle=solid}
> -      configurationEntries.add(new ConfigurationEntry().newBuilder()
> +      configurationEntries.add(ConfigurationEntry.newBuilder()
> {code}
> {code:title=NamingTest.java|borderStyle=solid}
> -          .set(NameResolverConfiguration.CACHE_TIMEOUT, this.TTL)
> +          .set(NameResolverConfiguration.CACHE_TIMEOUT, TTL)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)