You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangmiao1981 <gi...@git.apache.org> on 2016/05/07 00:09:18 UTC

[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

GitHub user wangmiao1981 opened a pull request:

    https://github.com/apache/spark/pull/12969

    [SPARK-15096][ML]:LogisticRegression MultiClassSummarizer numClasses can fail if no valid labels are found

    ## What changes were proposed in this pull request?
    
    (Please fill in changes proposed in this fix)
    Throw better exception when numClasses is empty and empty.max is thrown.
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    Add a new unit test, which calls histogram with empty numClasses.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangmiao1981/spark logisticR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12969
    
----
commit cfcb4b2fb72fda66784a111235f9fac611a9926f
Author: wm624@hotmail.com <wm...@hotmail.com>
Date:   2016-05-07T00:05:35Z

    add exception to LogisticRegression MultiClassSummarizer numClasses

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-219105722
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58583/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217931889
  
    **[Test build #58148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58148/consoleFull)** for PR 12969 at commit [`8e77ad0`](https://github.com/apache/spark/commit/8e77ad0318f3a82f0fb8f8a203646823a76de8fd).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217594214
  
    **[Test build #58042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58042/consoleFull)** for PR 12969 at commit [`cfcb4b2`](https://github.com/apache/spark/commit/cfcb4b2fb72fda66784a111235f9fac611a9926f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217921843
  
    **[Test build #58148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58148/consoleFull)** for PR 12969 at commit [`8e77ad0`](https://github.com/apache/spark/commit/8e77ad0318f3a82f0fb8f8a203646823a76de8fd).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12969#discussion_r62413167
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -744,7 +744,13 @@ private[classification] class MultiClassSummarizer extends Serializable {
       def countInvalid: Long = totalInvalidCnt
     
       /** @return The number of distinct labels in the input dataset. */
    -  def numClasses: Int = distinctMap.keySet.max + 1
    +  def numClasses: Int = try {
    +    distinctMap.keySet.max + 1
    +  } catch {
    +    case e: UnsupportedOperationException =>
    --- End diff --
    
    ... or is the correct behavior to return 0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217594244
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58042/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12969#discussion_r62420025
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -744,7 +744,13 @@ private[classification] class MultiClassSummarizer extends Serializable {
       def countInvalid: Long = totalInvalidCnt
     
       /** @return The number of distinct labels in the input dataset. */
    -  def numClasses: Int = distinctMap.keySet.max + 1
    +  def numClasses: Int = try {
    +    distinctMap.keySet.max + 1
    +  } catch {
    +    case e: UnsupportedOperationException =>
    --- End diff --
    
    I think returning 0 is reasonable. The inline comments of the JIRA, @jkbradley proposed the fix of throwing a better exception.
    
    I am glad to learn using require. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-219208737
  
    Merged to master/2.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-219096330
  
    **[Test build #58583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58583/consoleFull)** for PR 12969 at commit [`f4e2ee4`](https://github.com/apache/spark/commit/f4e2ee4d11025dafca7923195b54adeaa04ebed8).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12969#discussion_r62532641
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -744,7 +744,13 @@ private[classification] class MultiClassSummarizer extends Serializable {
       def countInvalid: Long = totalInvalidCnt
     
       /** @return The number of distinct labels in the input dataset. */
    -  def numClasses: Int = distinctMap.keySet.max + 1
    +  def numClasses: Int = try {
    +    distinctMap.keySet.max + 1
    +  } catch {
    +    case e: UnsupportedOperationException =>
    --- End diff --
    
    @srowen I made changes to return 0 when the hashtable is empty. 
    I found that 
    301       if (numInvalid != 0) {
    302        val msg = s"Classification labels should be in {0 to ${numClasses - 1} " +
    303          s"Found $numInvalid invalid labels."
    304        logError(msg)
    305        throw new SparkException(msg)
    306      }
    So, for the empty case, it will throw an exception anyway after train. Then, returning 0 or throw an exception won't make much difference. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-218910819
  
    @srowen I have made changes as we discussed. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-219105603
  
    **[Test build #58583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58583/consoleFull)** for PR 12969 at commit [`f4e2ee4`](https://github.com/apache/spark/commit/f4e2ee4d11025dafca7923195b54adeaa04ebed8).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217932007
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217591334
  
    **[Test build #58042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58042/consoleFull)** for PR 12969 at commit [`cfcb4b2`](https://github.com/apache/spark/commit/cfcb4b2fb72fda66784a111235f9fac611a9926f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217932009
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58148/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12969#discussion_r62428194
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -744,7 +744,13 @@ private[classification] class MultiClassSummarizer extends Serializable {
       def countInvalid: Long = totalInvalidCnt
     
       /** @return The number of distinct labels in the input dataset. */
    -  def numClasses: Int = distinctMap.keySet.max + 1
    +  def numClasses: Int = try {
    +    distinctMap.keySet.max + 1
    +  } catch {
    +    case e: UnsupportedOperationException =>
    --- End diff --
    
    Is the only result of returning 0 that histogram() returns an empty array? that seems ... fine. It's not meaningful but it's not wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/12969


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-219105720
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12969#discussion_r62525721
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -744,7 +744,13 @@ private[classification] class MultiClassSummarizer extends Serializable {
       def countInvalid: Long = totalInvalidCnt
     
       /** @return The number of distinct labels in the input dataset. */
    -  def numClasses: Int = distinctMap.keySet.max + 1
    +  def numClasses: Int = try {
    +    distinctMap.keySet.max + 1
    +  } catch {
    +    case e: UnsupportedOperationException =>
    --- End diff --
    
    @srowen Let me do some test about return 0 directly when the hashtable is empty and make changes accordingly. Thanks for your review!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12969#discussion_r62413154
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -744,7 +744,13 @@ private[classification] class MultiClassSummarizer extends Serializable {
       def countInvalid: Long = totalInvalidCnt
     
       /** @return The number of distinct labels in the input dataset. */
    -  def numClasses: Int = distinctMap.keySet.max + 1
    +  def numClasses: Int = try {
    +    distinctMap.keySet.max + 1
    +  } catch {
    +    case e: UnsupportedOperationException =>
    --- End diff --
    
    Are you trying to handle the case where the map is empty? why not handle it directly then?
    Just needs one new line of code, like: `require(distinctMap.nonEmpty)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12969#discussion_r63143517
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala ---
    @@ -256,6 +256,10 @@ class LogisticRegressionSuite
         assert(summarizer4.countInvalid === 2)
         assert(summarizer4.numClasses === 4)
     
    +    val summarizer5 = new MultiClassSummarizer
    +    assert(summarizer5.histogram.isEmpty === true)
    --- End diff --
    
    === true is redundant everywhere


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-218973390
  
    It seems like a good change, because several lower-level methods now return a reasonable result instead of an error. At a higher level, having 0 labels probably still results in some (better) error, or a trivial model, but that has at least improved the situation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/12969#issuecomment-217594243
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org