You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/10 22:59:27 UTC

[GitHub] [pulsar] merlimat opened a new pull request #10533: Removed AspectJ based metrics for ZooKeeper

merlimat opened a new pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533


   ### Motivation
   
   So far, we have been relying on a wacky approach to gather metrics for Zookeeper usage. That was done because ZK used not to have a decent set of exported metrics in server or client side. 
   
   We were relying on AspectJ to intercept specific points in ZooKeeper client/server execution and collect the data points and expose them through Prometheus.
   
   There are few problem with this approach: 
    1. It's hacky because we're jumping inside ZK undocumented code internals, which break between releases and there's overhead in the AspectJ interception.
    2. AspectJ doesn't work anymore with recent versions of Java 16+. I does not look like there is any work in progress to achieve that.
   
   Since we have already upgraded ZooKeeper to 3.6, it already has support for pluggable metrics provider and Prometheus is one of the options. There's no point anymore to continue doing the AspectJ hack.
   
   In separate PRs I'll add the ZK config and submit ZK Grafana dashboards.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #10533: Removed AspectJ based metrics for ZooKeeper

Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533#issuecomment-839299694


   @rdhabalia The metrics that ZooKeeper exports are going to be different, in names but also types. I will not be possible to maintain a compatibility layer here. 
   
   Even with that, I think that it would be much better to just move to the metrics supported by ZooKeeper instead of the current situation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #10533: Removed AspectJ based metrics for ZooKeeper

Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533#issuecomment-839208333


   > LGTM
   > 
   > Also, for reference, if we update to ZooKeeper 3.7.0 there is an official API to bootstrap ZooKeeper Server Nodes for production from Java code, instead of using internal ZooKeeper classes, that may change behaviour from one release to the next
   > 
   > https://zookeeper.apache.org/doc/current/apidocs/zookeeper-server/org/apache/zookeeper/server/embedded/ZooKeeperServerEmbedded.html
   
   Sounds good. We could go to 3.7.0 after Pulsar 2.8 is cut. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #10533: Removed AspectJ based metrics for ZooKeeper

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] linlinnn commented on pull request #10533: Removed AspectJ based metrics for ZooKeeper

Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533#issuecomment-837687426


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat edited a comment on pull request #10533: Removed AspectJ based metrics for ZooKeeper

Posted by GitBox <gi...@apache.org>.
merlimat edited a comment on pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533#issuecomment-839299694


   @rdhabalia The metrics that ZooKeeper exports are going to be different, in names but also types. It will not be possible to maintain a compatibility layer here. 
   
   Even with that, I think that it would be much better to just move to the metrics supported by ZooKeeper instead of the current situation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org