You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2022/05/20 17:06:54 UTC
[allura:tickets] #8431 handle git symlinks better
---
** [tickets:#8431] handle git symlinks better**
**Status:** in-progress
**Milestone:** unreleased
**Created:** Fri May 20, 2022 05:06 PM UTC by Dave Brondsema
**Last Updated:** Fri May 20, 2022 05:06 PM UTC
**Owner:** Dave Brondsema
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8431 handle dir/file/symlink changes better
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review
- **Comment**:
db/8431
---
** [tickets:#8431] handle dir/file/symlink changes better**
**Status:** review
**Milestone:** unreleased
**Created:** Fri May 20, 2022 05:06 PM UTC by Dave Brondsema
**Last Updated:** Mon May 23, 2022 02:55 PM UTC
**Owner:** Dave Brondsema
If `foo` was a directory and then in the next commit it becomes a file (or a symlink in git) then this error occurs
```pytb
File "/src/allura/Allura/allura/controllers/repository.py", line 688, in index
is_text = filepath and tree.get_blob_by_path(filepath) and tree.get_blob_by_path(filepath).has_html_view
File "/src/allura/Allura/allura/model/repository.py", line 1372, in get_blob_by_path
obj = self.get_obj_by_path(path)
File "/src/allura/Allura/allura/model/repository.py", line 1366, in get_obj_by_path
obj = obj[p]
TypeError: 'Blob' object is not subscriptable
```
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8431 handle dir/file/symlink changes better
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
---
** [tickets:#8431] handle dir/file/symlink changes better**
**Status:** closed
**Milestone:** unreleased
**Created:** Fri May 20, 2022 05:06 PM UTC by Dave Brondsema
**Last Updated:** Mon May 23, 2022 03:57 PM UTC
**Owner:** Dave Brondsema
If `foo` was a directory and then in the next commit it becomes a file (or a symlink in git) then this error occurs
```pytb
File "/src/allura/Allura/allura/controllers/repository.py", line 688, in index
is_text = filepath and tree.get_blob_by_path(filepath) and tree.get_blob_by_path(filepath).has_html_view
File "/src/allura/Allura/allura/model/repository.py", line 1372, in get_blob_by_path
obj = self.get_obj_by_path(path)
File "/src/allura/Allura/allura/model/repository.py", line 1366, in get_obj_by_path
obj = obj[p]
TypeError: 'Blob' object is not subscriptable
```
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8431 handle dir/file/symlink changes better
Posted by Dave Brondsema <da...@brondsema.net>.
- **summary**: handle git symlinks better --> handle dir/file/symlink changes better
- Description has changed:
Diff:
~~~~
--- old
+++ new
@@ -0,0 +1,11 @@
+If `foo` was a directory and then in the next commit it becomes a file (or a symlink in git) then this error occurs
+
+```pytb
+File "/src/allura/Allura/allura/controllers/repository.py", line 688, in index
+ is_text = filepath and tree.get_blob_by_path(filepath) and tree.get_blob_by_path(filepath).has_html_view
+ File "/src/allura/Allura/allura/model/repository.py", line 1372, in get_blob_by_path
+ obj = self.get_obj_by_path(path)
+ File "/src/allura/Allura/allura/model/repository.py", line 1366, in get_obj_by_path
+ obj = obj[p]
+TypeError: 'Blob' object is not subscriptable
+```
~~~~
---
** [tickets:#8431] handle dir/file/symlink changes better**
**Status:** in-progress
**Milestone:** unreleased
**Created:** Fri May 20, 2022 05:06 PM UTC by Dave Brondsema
**Last Updated:** Fri May 20, 2022 05:06 PM UTC
**Owner:** Dave Brondsema
If `foo` was a directory and then in the next commit it becomes a file (or a symlink in git) then this error occurs
```pytb
File "/src/allura/Allura/allura/controllers/repository.py", line 688, in index
is_text = filepath and tree.get_blob_by_path(filepath) and tree.get_blob_by_path(filepath).has_html_view
File "/src/allura/Allura/allura/model/repository.py", line 1372, in get_blob_by_path
obj = self.get_obj_by_path(path)
File "/src/allura/Allura/allura/model/repository.py", line 1366, in get_obj_by_path
obj = obj[p]
TypeError: 'Blob' object is not subscriptable
```
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.