You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/22 07:56:39 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable

pitrou commented on a change in pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#discussion_r492540465



##########
File path: cpp/src/arrow/compute/kernel.h
##########
@@ -664,7 +664,7 @@ struct VectorKernel : public ArrayKernel {
 using ScalarAggregateConsume = std::function<void(KernelContext*, const ExecBatch&)>;
 
 using ScalarAggregateMerge =
-    std::function<void(KernelContext*, const KernelState&, KernelState*)>;
+    std::function<void(KernelContext*, KernelState&, KernelState*)>;

Review comment:
       If it can be moved, shouldn't you pass `KernelState&&` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org