You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/02/22 11:33:14 UTC
Review Request 56923: Add polyfills for Array.includes and
String.includes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56923/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-20112
https://issues.apache.org/jira/browse/AMBARI-20112
Repository: ambari
Description
-------
Some tests randomly fail because of undefined (sometimes?!) `Array.includes`. Adding polyfill will fix this.
Diffs
-----
ambari-web/app/styles/theme/bootstrap-ambari.css af78310
ambari-web/test/init_test.js df64cbe
Diff: https://reviews.apache.org/r/56923/diff/
Testing
-------
20421 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 56923: Add polyfills for Array.includes and
String.includes
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56923/#review166354
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Feb. 22, 2017, 11:33 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56923/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 11:33 a.m.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-20112
> https://issues.apache.org/jira/browse/AMBARI-20112
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some tests randomly fail because of undefined (sometimes?!) `Array.includes`. Adding polyfill will fix this.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/theme/bootstrap-ambari.css af78310
> ambari-web/test/init_test.js df64cbe
>
> Diff: https://reviews.apache.org/r/56923/diff/
>
>
> Testing
> -------
>
> 20421 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>