You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@quickstep.apache.org by "Zuyu Zhang (JIRA)" <ji...@apache.org> on 2017/09/12 13:17:00 UTC
[jira] [Updated] (QUICKSTEP-99) \analyze-ing a VarChar attribute in
a partitioned relation crashes
[ https://issues.apache.org/jira/browse/QUICKSTEP-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zuyu Zhang updated QUICKSTEP-99:
--------------------------------
Description:
A fix is as following, credits to [~jianqiao], but we may need to think throughout this issue beyond this quick fix.
This issue is that a VarChar attribute is a reference during the analyzing.
{code}
diff --git a/types/operations/comparisons/AsciiStringComparators-inl.hpp b/types/operations/comparisons/AsciiStringComparators-inl.hpp
index 87d71689..3f381240 100644
--- a/types/operations/comparisons/AsciiStringComparators-inl.hpp
+++ b/types/operations/comparisons/AsciiStringComparators-inl.hpp
@@ -551,6 +551,7 @@ TypedValue AsciiStringUncheckedComparator<ComparisonFunctor,
}
});
+ new_value.ensureNotReference();
return new_value;
}
{code}
was:
A fix is as following, credits to [~jianqiao], but we may need to think throughout this issue beyond this quick fix.
{code}
diff --git a/types/operations/comparisons/AsciiStringComparators-inl.hpp b/types/operations/comparisons/AsciiStringComparators-inl.hpp
index 87d71689..3f381240 100644
--- a/types/operations/comparisons/AsciiStringComparators-inl.hpp
+++ b/types/operations/comparisons/AsciiStringComparators-inl.hpp
@@ -551,6 +551,7 @@ TypedValue AsciiStringUncheckedComparator<ComparisonFunctor,
}
});
+ new_value.ensureNotReference();
return new_value;
}
{code}
> \analyze-ing a VarChar attribute in a partitioned relation crashes
> ------------------------------------------------------------------
>
> Key: QUICKSTEP-99
> URL: https://issues.apache.org/jira/browse/QUICKSTEP-99
> Project: Apache Quickstep
> Issue Type: Bug
> Components: Types
> Reporter: Zuyu Zhang
>
> A fix is as following, credits to [~jianqiao], but we may need to think throughout this issue beyond this quick fix.
> This issue is that a VarChar attribute is a reference during the analyzing.
> {code}
> diff --git a/types/operations/comparisons/AsciiStringComparators-inl.hpp b/types/operations/comparisons/AsciiStringComparators-inl.hpp
> index 87d71689..3f381240 100644
> --- a/types/operations/comparisons/AsciiStringComparators-inl.hpp
> +++ b/types/operations/comparisons/AsciiStringComparators-inl.hpp
> @@ -551,6 +551,7 @@ TypedValue AsciiStringUncheckedComparator<ComparisonFunctor,
> }
> });
> + new_value.ensureNotReference();
> return new_value;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)