You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/08 07:35:31 UTC
[GitHub] [flink] wangxlong opened a new pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
wangxlong opened a new pull request #14328:
URL: https://github.com/apache/flink/pull/14328
…s operator when element types are different but castable
## What is the purpose of the change
Array type supports equals and not_equals operator when element types are different but castable
## Brief change log
Add the cast code between array and array
## Verifying this change
This change added tests and can be verified as follows:
1. Add test to ScalarOperatorsTest#testCompareOperator to verify the comparison between array and array
2. Add test to ScalarOperatorsTest#testCast to verify that it is castable between array and array
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no / don't know)
- The runtime per-record code paths (performance sensitive): (no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no / don't know)
- The S3 file system connector: (no / don't know)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
}, {
"hash" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722",
"triggerID" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4a79b01e25ccc9ef50019bcae53da401f36041e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625)
* d05d4f7df4446697093e8feea44c75b8a3a60722 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740441995
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b4a79b01e25ccc9ef50019bcae53da401f36041e (Tue Dec 08 07:38:24 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
}, {
"hash" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722",
"triggerID" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"triggerType" : "PUSH"
}, {
"hash" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10742",
"triggerID" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10742)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
}, {
"hash" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722",
"triggerID" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"triggerType" : "PUSH"
}, {
"hash" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10742",
"triggerID" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10742)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
}, {
"hash" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722",
"triggerID" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d05d4f7df4446697093e8feea44c75b8a3a60722 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
}, {
"hash" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722",
"triggerID" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"triggerType" : "PUSH"
}, {
"hash" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10742",
"triggerID" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d05d4f7df4446697093e8feea44c75b8a3a60722 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722)
* 3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10742)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4a79b01e25ccc9ef50019bcae53da401f36041e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4a79b01e25ccc9ef50019bcae53da401f36041e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
}, {
"hash" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4a79b01e25ccc9ef50019bcae53da401f36041e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625)
* d05d4f7df4446697093e8feea44c75b8a3a60722 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #14328:
URL: https://github.com/apache/flink/pull/14328#discussion_r538130793
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarOperatorsTest.scala
##########
@@ -94,10 +94,33 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
"x'68656C6C6F20636F6465' > x'68656C6C6F2063617374'",
"true")
+ // between array and array
Review comment:
Thanks @wangxlong. I will do a full review soon. Could you use the new test base?
`org.apache.flink.table.planner.functions.CastFunctionITCase`
It was recently added for casting rows to rows. It will be further extended as part of FLINK-17321.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangxlong commented on a change in pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #14328:
URL: https://github.com/apache/flink/pull/14328#discussion_r538207920
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarOperatorsTest.scala
##########
@@ -94,10 +94,33 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
"x'68656C6C6F20636F6465' > x'68656C6C6F2063617374'",
"true")
+ // between array and array
Review comment:
Thanks @twalthr. Yes, I will update it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangxlong commented on a change in pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #14328:
URL: https://github.com/apache/flink/pull/14328#discussion_r540142298
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarOperatorsTest.scala
##########
@@ -94,10 +94,33 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
"x'68656C6C6F20636F6465' > x'68656C6C6F2063617374'",
"true")
+ // between array and array
Review comment:
It is ready to be reviewed. Thanks for having a look in your free time. @twalthr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14328: [FLINK-19659][table-planner] Array type supports equals and not_equal…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14328:
URL: https://github.com/apache/flink/pull/14328#issuecomment-740445577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10625",
"triggerID" : "b4a79b01e25ccc9ef50019bcae53da401f36041e",
"triggerType" : "PUSH"
}, {
"hash" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722",
"triggerID" : "d05d4f7df4446697093e8feea44c75b8a3a60722",
"triggerType" : "PUSH"
}, {
"hash" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d05d4f7df4446697093e8feea44c75b8a3a60722 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10722)
* 3d82f6f5f542bb0edeaf4faaefcf59e910d43a2c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org