[GitHub] [spark] ulysses-you commented on a diff in pull request #41628: [SPARK-38230][SQL] InsertIntoHadoopFsRelationCommand unnecessarily fetches details of partitions

["ulysses-you (via GitHub)" <gi...@apache.org>]

ulysses-you commented on code in PR #41628:
URL: https://github.com/apache/spark/pull/41628#discussion_r1280038895


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala:
##########
@@ -162,33 +193,36 @@ case class InsertIntoHadoopFsRelationCommand(
                 retainData = true /* already deleted */).run(sparkSession)
             }
           }
+          // The `customPartitionLocations` is getting from writing paths. Hence, it need to move
+          // files from `qualifiedOutputPath` to custom location.
+          if (updatedPartitions.nonEmpty && dynamicPartitionOverwrite) {

Review Comment:
   IIUC, the goal of this pr is lazily listing partition by name using the returned modfied partition specs with dynamic partition write. Does the change related to this pr?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org