You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by ca...@apache.org on 2008/01/17 19:19:01 UTC

svn commit: r612911 - /logging/log4j/trunk/src/main/java/org/apache/log4j/net/TelnetAppender.java

Author: carnold
Date: Thu Jan 17 10:18:59 2008
New Revision: 612911

URL: http://svn.apache.org/viewvc?rev=612911&view=rev
Log:
Bug 44109: TelnetAppender throws null pointers at log time when socket couldn't be opened

Modified:
    logging/log4j/trunk/src/main/java/org/apache/log4j/net/TelnetAppender.java

Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/net/TelnetAppender.java
URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/net/TelnetAppender.java?rev=612911&r1=612910&r2=612911&view=diff
==============================================================================
--- logging/log4j/trunk/src/main/java/org/apache/log4j/net/TelnetAppender.java (original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/net/TelnetAppender.java Thu Jan 17 10:18:59 2008
@@ -103,17 +103,19 @@
   /** Handles a log event.  For this appender, that means writing the
     message to each connected client.  */
   protected void append(LoggingEvent event) {
-    sh.send(this.layout.format(event));
-    if(layout.ignoresThrowable()) {
-      String[] s = event.getThrowableStrRep();
-      if (s != null) {
-	int len = s.length;
-	for(int i = 0; i < len; i++) {
-	  sh.send(s[i]);
-	  sh.send(Layout.LINE_SEP);
-	}
+      if(sh != null) {
+        sh.send(this.layout.format(event));
+        if(layout.ignoresThrowable()) {
+            String[] s = event.getThrowableStrRep();
+            if (s != null) {
+	            int len = s.length;
+	            for(int i = 0; i < len; i++) {
+	                sh.send(s[i]);
+	                sh.send(Layout.LINE_SEP);
+	            }
+            }
+        }
       }
-    }
   }
 
   //---------------------------------------------------------- SocketHandler:



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org