You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Gerhard Petracek <ge...@gmail.com> on 2012/06/09 12:11:41 UTC
Re: git commit: DELTASPIKE-189 revert removing of the module
hi,
i would like to continue with [1] -> please don't revert it all the time
(without fixing [2])!
regards,
gerhard
[1] https://issues.apache.org/jira/browse/DELTASPIKE-102
[2] https://issues.apache.org/jira/browse/DELTASPIKE-189
2012/6/9 <st...@apache.org>
> Updated Branches:
> refs/heads/master 5b43de842 -> d10187829
>
>
> DELTASPIKE-189 revert removing of the module
>
> damn, commenting out a module is NOT A FIX!
> How should we know it's solved if we dont have it in here?
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/d1018782
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/d1018782
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/d1018782
>
> Branch: refs/heads/master
> Commit: d10187829685222aa6c639d638d37811bdccc0af
> Parents: 5b43de8
> Author: Mark Struberg <st...@apache.org>
> Authored: Sat Jun 9 09:56:16 2012 +0200
> Committer: Mark Struberg <st...@apache.org>
> Committed: Sat Jun 9 09:56:16 2012 +0200
>
> ----------------------------------------------------------------------
> deltaspike/cdictrl/pom.xml | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/d1018782/deltaspike/cdictrl/pom.xml
> ----------------------------------------------------------------------
> diff --git a/deltaspike/cdictrl/pom.xml b/deltaspike/cdictrl/pom.xml
> index 1d886ed..6b0e39f 100644
> --- a/deltaspike/cdictrl/pom.xml
> +++ b/deltaspike/cdictrl/pom.xml
> @@ -38,6 +38,6 @@
> <module>tck</module>
> <module>impl-owb</module>
> <module>impl-weld</module>
> - <!--module>impl-openejb</module-->
> + <module>impl-openejb</module>
> </modules>
> </project>
>
>
Re: git commit: DELTASPIKE-189 revert removing of the module
Posted by Gerhard Petracek <ge...@gmail.com>.
our sonar server allows that not everybody needs a local sonar setup (which
is still needed with mvn sonar:sonar).
however, thx for fixing it.
regards,
gerhard
2012/6/10 Mark Struberg <st...@yahoo.de>
> You can start sonar locally with maven sonar:sonar. You can also trigger
> the sonar checks locally from within IDEA. That's all you need to check
> them.
>
>
> Also as I said in another mail, I'll fix this once I'm back from vacation!
>
>
> LieGrue,
> strub
>
>
> ----- Original Message -----
> > From: Gerhard Petracek <ge...@gmail.com>
> > To: deltaspike-dev@incubator.apache.org
> > Cc:
> > Sent: Saturday, June 9, 2012 10:35 PM
> > Subject: Re: git commit: DELTASPIKE-189 revert removing of the module
> >
> > no - we have the stacktrace and it won't change without a commit which
> > tries to fix it.
> > to keep it enabled (-> failing) >without< such a commit just blocks the
> > progress of fixing sonar findings (not everybody has a local sonar
> setup).
> > you are welcome to uncomment it as soon as you have a potential fix
> (before
> > that it doesn't make sense).
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2012/6/9 Mark Struberg <st...@yahoo.de>
> >
> >> gerhard, we can only fix it when this is enabled. I will fix this once
> >> back from vacation.
> >> Commenting out the module last time did led to not having this issue
> >> fixed for months. please let the module enabled in the build.In the
> worst
> >> case we forget to enable it before the next release.
> >>
> >> LieGrue,
> >> strub
> >>
> >>
> >> ----- Original Message -----
> >> > From: Gerhard Petracek <ge...@gmail.com>
> >> > To: deltaspike-dev@incubator.apache.org
> >> > Cc:
> >> > Sent: Saturday, June 9, 2012 12:11 PM
> >> > Subject: Re: git commit: DELTASPIKE-189 revert removing of the module
> >> >
> >> > hi,
> >> >
> >> > i would like to continue with [1] -> please don't revert it all
> > the time
> >> > (without fixing [2])!
> >> >
> >> > regards,
> >> > gerhard
> >> >
> >> > [1] https://issues.apache.org/jira/browse/DELTASPIKE-102
> >> > [2] https://issues.apache.org/jira/browse/DELTASPIKE-189
> >> >
> >> >
> >> >
> >> > 2012/6/9 <st...@apache.org>
> >> >
> >> >> Updated Branches:
> >> >> refs/heads/master 5b43de842 -> d10187829
> >> >>
> >> >>
> >> >> DELTASPIKE-189 revert removing of the module
> >> >>
> >> >> damn, commenting out a module is NOT A FIX!
> >> >> How should we know it's solved if we dont have it in here?
> >> >>
> >> >>
> >> >> Project:
> >> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
> >> >> Commit:
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/d1018782
> >> >> Tree:
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/d1018782
> >> >> Diff:
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/d1018782
> >> >>
> >> >> Branch: refs/heads/master
> >> >> Commit: d10187829685222aa6c639d638d37811bdccc0af
> >> >> Parents: 5b43de8
> >> >> Author: Mark Struberg <st...@apache.org>
> >> >> Authored: Sat Jun 9 09:56:16 2012 +0200
> >> >> Committer: Mark Struberg <st...@apache.org>
> >> >> Committed: Sat Jun 9 09:56:16 2012 +0200
> >> >>
> >> >>
> > ----------------------------------------------------------------------
> >> >> deltaspike/cdictrl/pom.xml | 2 +-
> >> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> >>
> > ----------------------------------------------------------------------
> >> >>
> >> >>
> >> >>
> >> >>
> >> >
> >>
> >
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/d1018782/deltaspike/cdictrl/pom.xml
> >> >>
> > ----------------------------------------------------------------------
> >> >> diff --git a/deltaspike/cdictrl/pom.xml
> > b/deltaspike/cdictrl/pom.xml
> >> >> index 1d886ed..6b0e39f 100644
> >> >> --- a/deltaspike/cdictrl/pom.xml
> >> >> +++ b/deltaspike/cdictrl/pom.xml
> >> >> @@ -38,6 +38,6 @@
> >> >> <module>tck</module>
> >> >> <module>impl-owb</module>
> >> >> <module>impl-weld</module>
> >> >> - <!--module>impl-openejb</module-->
> >> >> + <module>impl-openejb</module>
> >> >> </modules>
> >> >> </project>
> >> >>
> >> >>
> >> >
> >>
> >
>
Re: git commit: DELTASPIKE-189 revert removing of the module
Posted by Mark Struberg <st...@yahoo.de>.
You can start sonar locally with maven sonar:sonar. You can also trigger the sonar checks locally from within IDEA. That's all you need to check them.
Also as I said in another mail, I'll fix this once I'm back from vacation!
LieGrue,
strub
----- Original Message -----
> From: Gerhard Petracek <ge...@gmail.com>
> To: deltaspike-dev@incubator.apache.org
> Cc:
> Sent: Saturday, June 9, 2012 10:35 PM
> Subject: Re: git commit: DELTASPIKE-189 revert removing of the module
>
> no - we have the stacktrace and it won't change without a commit which
> tries to fix it.
> to keep it enabled (-> failing) >without< such a commit just blocks the
> progress of fixing sonar findings (not everybody has a local sonar setup).
> you are welcome to uncomment it as soon as you have a potential fix (before
> that it doesn't make sense).
>
> regards,
> gerhard
>
>
>
> 2012/6/9 Mark Struberg <st...@yahoo.de>
>
>> gerhard, we can only fix it when this is enabled. I will fix this once
>> back from vacation.
>> Commenting out the module last time did led to not having this issue
>> fixed for months. please let the module enabled in the build.In the worst
>> case we forget to enable it before the next release.
>>
>> LieGrue,
>> strub
>>
>>
>> ----- Original Message -----
>> > From: Gerhard Petracek <ge...@gmail.com>
>> > To: deltaspike-dev@incubator.apache.org
>> > Cc:
>> > Sent: Saturday, June 9, 2012 12:11 PM
>> > Subject: Re: git commit: DELTASPIKE-189 revert removing of the module
>> >
>> > hi,
>> >
>> > i would like to continue with [1] -> please don't revert it all
> the time
>> > (without fixing [2])!
>> >
>> > regards,
>> > gerhard
>> >
>> > [1] https://issues.apache.org/jira/browse/DELTASPIKE-102
>> > [2] https://issues.apache.org/jira/browse/DELTASPIKE-189
>> >
>> >
>> >
>> > 2012/6/9 <st...@apache.org>
>> >
>> >> Updated Branches:
>> >> refs/heads/master 5b43de842 -> d10187829
>> >>
>> >>
>> >> DELTASPIKE-189 revert removing of the module
>> >>
>> >> damn, commenting out a module is NOT A FIX!
>> >> How should we know it's solved if we dont have it in here?
>> >>
>> >>
>> >> Project:
>> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
>> >> Commit:
>> >>
>> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/d1018782
>> >> Tree:
>> >>
>> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/d1018782
>> >> Diff:
>> >>
>> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/d1018782
>> >>
>> >> Branch: refs/heads/master
>> >> Commit: d10187829685222aa6c639d638d37811bdccc0af
>> >> Parents: 5b43de8
>> >> Author: Mark Struberg <st...@apache.org>
>> >> Authored: Sat Jun 9 09:56:16 2012 +0200
>> >> Committer: Mark Struberg <st...@apache.org>
>> >> Committed: Sat Jun 9 09:56:16 2012 +0200
>> >>
>> >>
> ----------------------------------------------------------------------
>> >> deltaspike/cdictrl/pom.xml | 2 +-
>> >> 1 files changed, 1 insertions(+), 1 deletions(-)
>> >>
> ----------------------------------------------------------------------
>> >>
>> >>
>> >>
>> >>
>> >
>>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/d1018782/deltaspike/cdictrl/pom.xml
>> >>
> ----------------------------------------------------------------------
>> >> diff --git a/deltaspike/cdictrl/pom.xml
> b/deltaspike/cdictrl/pom.xml
>> >> index 1d886ed..6b0e39f 100644
>> >> --- a/deltaspike/cdictrl/pom.xml
>> >> +++ b/deltaspike/cdictrl/pom.xml
>> >> @@ -38,6 +38,6 @@
>> >> <module>tck</module>
>> >> <module>impl-owb</module>
>> >> <module>impl-weld</module>
>> >> - <!--module>impl-openejb</module-->
>> >> + <module>impl-openejb</module>
>> >> </modules>
>> >> </project>
>> >>
>> >>
>> >
>>
>
Re: git commit: DELTASPIKE-189 revert removing of the module
Posted by Gerhard Petracek <ge...@gmail.com>.
no - we have the stacktrace and it won't change without a commit which
tries to fix it.
to keep it enabled (-> failing) >without< such a commit just blocks the
progress of fixing sonar findings (not everybody has a local sonar setup).
you are welcome to uncomment it as soon as you have a potential fix (before
that it doesn't make sense).
regards,
gerhard
2012/6/9 Mark Struberg <st...@yahoo.de>
> gerhard, we can only fix it when this is enabled. I will fix this once
> back from vacation.
> Commenting out the module last time did led to not having this issue
> fixed for months. please let the module enabled in the build.In the worst
> case we forget to enable it before the next release.
>
> LieGrue,
> strub
>
>
> ----- Original Message -----
> > From: Gerhard Petracek <ge...@gmail.com>
> > To: deltaspike-dev@incubator.apache.org
> > Cc:
> > Sent: Saturday, June 9, 2012 12:11 PM
> > Subject: Re: git commit: DELTASPIKE-189 revert removing of the module
> >
> > hi,
> >
> > i would like to continue with [1] -> please don't revert it all the time
> > (without fixing [2])!
> >
> > regards,
> > gerhard
> >
> > [1] https://issues.apache.org/jira/browse/DELTASPIKE-102
> > [2] https://issues.apache.org/jira/browse/DELTASPIKE-189
> >
> >
> >
> > 2012/6/9 <st...@apache.org>
> >
> >> Updated Branches:
> >> refs/heads/master 5b43de842 -> d10187829
> >>
> >>
> >> DELTASPIKE-189 revert removing of the module
> >>
> >> damn, commenting out a module is NOT A FIX!
> >> How should we know it's solved if we dont have it in here?
> >>
> >>
> >> Project:
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
> >> Commit:
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/d1018782
> >> Tree:
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/d1018782
> >> Diff:
> >>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/d1018782
> >>
> >> Branch: refs/heads/master
> >> Commit: d10187829685222aa6c639d638d37811bdccc0af
> >> Parents: 5b43de8
> >> Author: Mark Struberg <st...@apache.org>
> >> Authored: Sat Jun 9 09:56:16 2012 +0200
> >> Committer: Mark Struberg <st...@apache.org>
> >> Committed: Sat Jun 9 09:56:16 2012 +0200
> >>
> >> ----------------------------------------------------------------------
> >> deltaspike/cdictrl/pom.xml | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> ----------------------------------------------------------------------
> >>
> >>
> >>
> >>
> >
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/d1018782/deltaspike/cdictrl/pom.xml
> >> ----------------------------------------------------------------------
> >> diff --git a/deltaspike/cdictrl/pom.xml b/deltaspike/cdictrl/pom.xml
> >> index 1d886ed..6b0e39f 100644
> >> --- a/deltaspike/cdictrl/pom.xml
> >> +++ b/deltaspike/cdictrl/pom.xml
> >> @@ -38,6 +38,6 @@
> >> <module>tck</module>
> >> <module>impl-owb</module>
> >> <module>impl-weld</module>
> >> - <!--module>impl-openejb</module-->
> >> + <module>impl-openejb</module>
> >> </modules>
> >> </project>
> >>
> >>
> >
>
Re: git commit: DELTASPIKE-189 revert removing of the module
Posted by Mark Struberg <st...@yahoo.de>.
gerhard, we can only fix it when this is enabled. I will fix this once back from vacation.
Commenting out the module last time did led to not having this issue
fixed for months. please let the module enabled in the build.In the worst case we forget to enable it before the next release.
LieGrue,
strub
----- Original Message -----
> From: Gerhard Petracek <ge...@gmail.com>
> To: deltaspike-dev@incubator.apache.org
> Cc:
> Sent: Saturday, June 9, 2012 12:11 PM
> Subject: Re: git commit: DELTASPIKE-189 revert removing of the module
>
> hi,
>
> i would like to continue with [1] -> please don't revert it all the time
> (without fixing [2])!
>
> regards,
> gerhard
>
> [1] https://issues.apache.org/jira/browse/DELTASPIKE-102
> [2] https://issues.apache.org/jira/browse/DELTASPIKE-189
>
>
>
> 2012/6/9 <st...@apache.org>
>
>> Updated Branches:
>> refs/heads/master 5b43de842 -> d10187829
>>
>>
>> DELTASPIKE-189 revert removing of the module
>>
>> damn, commenting out a module is NOT A FIX!
>> How should we know it's solved if we dont have it in here?
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/d1018782
>> Tree:
>> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/d1018782
>> Diff:
>> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/d1018782
>>
>> Branch: refs/heads/master
>> Commit: d10187829685222aa6c639d638d37811bdccc0af
>> Parents: 5b43de8
>> Author: Mark Struberg <st...@apache.org>
>> Authored: Sat Jun 9 09:56:16 2012 +0200
>> Committer: Mark Struberg <st...@apache.org>
>> Committed: Sat Jun 9 09:56:16 2012 +0200
>>
>> ----------------------------------------------------------------------
>> deltaspike/cdictrl/pom.xml | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/d1018782/deltaspike/cdictrl/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/deltaspike/cdictrl/pom.xml b/deltaspike/cdictrl/pom.xml
>> index 1d886ed..6b0e39f 100644
>> --- a/deltaspike/cdictrl/pom.xml
>> +++ b/deltaspike/cdictrl/pom.xml
>> @@ -38,6 +38,6 @@
>> <module>tck</module>
>> <module>impl-owb</module>
>> <module>impl-weld</module>
>> - <!--module>impl-openejb</module-->
>> + <module>impl-openejb</module>
>> </modules>
>> </project>
>>
>>
>