You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/03 18:40:51 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14501: Fix set task instance form test

ephraimbuddy commented on a change in pull request #14501:
URL: https://github.com/apache/airflow/pull/14501#discussion_r586684031



##########
File path: tests/api_connexion/schemas/test_task_instance_schema.py
##########
@@ -199,7 +199,6 @@ def test_success(self):
     @parameterized.expand(
         [
             ({"task_id": None},),
-            ({"include_future": "True"},),

Review comment:
       We shouldn't delete this, rather we should use marshmallow none truthy string. Please add it back and replace "True" with "mystring"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org