You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/01/10 12:43:45 UTC
Review Request: SQOOP-825 Warning for incorrect usage of hive parameters is
not checking HIVE_HOME correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8918/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've put the missing "!" into the condition.
This addresses bug SQOP-825.
https://issues.apache.org/jira/browse/SQOP-825
Diffs
-----
src/java/org/apache/sqoop/tool/BaseSqoopTool.java c0221c97fc6e2fb971c384ee8e9a7b73915342dc
Diff: https://reviews.apache.org/r/8918/diff/
Testing
-------
I've verified that logs from all unit tests do not show this warning and also run this change on several conditions on real cluster.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-825 Warning for incorrect usage of hive parameters
is not checking HIVE_HOME correctly
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8918/#review15239
-----------------------------------------------------------
Ship it!
I missed it last time when I was reviewing. Thanks for catching it!
- Cheolsoo Park
On Jan. 10, 2013, 11:43 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8918/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2013, 11:43 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've put the missing "!" into the condition.
>
>
> This addresses bug SQOP-825.
> https://issues.apache.org/jira/browse/SQOP-825
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java c0221c97fc6e2fb971c384ee8e9a7b73915342dc
>
> Diff: https://reviews.apache.org/r/8918/diff/
>
>
> Testing
> -------
>
> I've verified that logs from all unit tests do not show this warning and also run this change on several conditions on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>