You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Srivatsan Sridharan (JIRA)" <ji...@apache.org> on 2007/08/29 22:38:22 UTC
[jira] Created: (SM-1044) Routing based on message property and set
new property on the message in EIP content based router
Routing based on message property and set new property on the message in EIP content based router
-------------------------------------------------------------------------------------------------
Key: SM-1044
URL: https://issues.apache.org/activemq/browse/SM-1044
Project: ServiceMix
Issue Type: New Feature
Components: servicemix-eip
Affects Versions: 3.1
Environment: Windows, JBoss-4.0.4-GA using Servicemix deployer
Reporter: Srivatsan Sridharan
Priority: Minor
Attachments: SwitchPredicate.java, XPathPredicate.java
SwitchPredicate.java (available in Servicemix trunk) routes based on the (boolean) value of the property set on the message exchange. It would be good to have it
1) route based on the value (not particularly boolean) of a property set on the message.
2) set additional property on the message when the evaluation of property value is true.
SwitchPredicate.java attached herewith has the changes to address the above.
XPathPredicate.java attached herewith has the changes to set additional property in the ContentBasedRouter.
Please let me know if this is the right approach.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1044) Routing based on message property and set
new property on the message in EIP content based router
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated SM-1044:
--------------------------------
Patch Info: [Patch Available]
> Routing based on message property and set new property on the message in EIP content based router
> -------------------------------------------------------------------------------------------------
>
> Key: SM-1044
> URL: https://issues.apache.org/activemq/browse/SM-1044
> Project: ServiceMix
> Issue Type: New Feature
> Components: servicemix-eip
> Affects Versions: 3.1
> Environment: Windows, JBoss-4.0.4-GA using Servicemix deployer
> Reporter: Srivatsan Sridharan
> Priority: Minor
> Attachments: SwitchPredicate.java, XPathPredicate.java
>
>
> SwitchPredicate.java (available in Servicemix trunk) routes based on the (boolean) value of the property set on the message exchange. It would be good to have it
> 1) route based on the value (not particularly boolean) of a property set on the message.
> 2) set additional property on the message when the evaluation of property value is true.
> SwitchPredicate.java attached herewith has the changes to address the above.
>
> XPathPredicate.java attached herewith has the changes to set additional property in the ContentBasedRouter.
> Please let me know if this is the right approach.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1044) Routing based on message property and
set new property on the message in EIP content based router
Posted by "Srivatsan Sridharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40295 ]
Srivatsan Sridharan commented on SM-1044:
-----------------------------------------
Thanks Guillaume. We have implemented our own Predicates as the requirement is too specific. Closing this issue.
> Routing based on message property and set new property on the message in EIP content based router
> -------------------------------------------------------------------------------------------------
>
> Key: SM-1044
> URL: https://issues.apache.org/activemq/browse/SM-1044
> Project: ServiceMix
> Issue Type: New Feature
> Components: servicemix-eip
> Affects Versions: 3.1
> Environment: Windows, JBoss-4.0.4-GA using Servicemix deployer
> Reporter: Srivatsan Sridharan
> Priority: Minor
> Attachments: SwitchPredicate.java, XPathPredicate.java
>
>
> SwitchPredicate.java (available in Servicemix trunk) routes based on the (boolean) value of the property set on the message exchange. It would be good to have it
> 1) route based on the value (not particularly boolean) of a property set on the message.
> 2) set additional property on the message when the evaluation of property value is true.
> SwitchPredicate.java attached herewith has the changes to address the above.
>
> XPathPredicate.java attached herewith has the changes to set additional property in the ContentBasedRouter.
> Please let me know if this is the right approach.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SM-1044) Routing based on message property
and set new property on the message in EIP content based router
Posted by Thomas Termin <tt...@blue-elephant-systems.com>.
Sorry for long response time. I will look into your patch as soon as
possible.
Cheers,
Thomas Termin
Vinod Chhabria (JIRA) wrote:
> [ https://issues.apache.org/activemq/browse/SM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40120 ]
>
> Vinod Chhabria commented on SM-1044:
> ------------------------------------
>
> We think this is a good enhancement to the existing predicate classes. Can you please approve so we can go ahead and add this to our servicemix installation. We do not want to apply any patch that will not be available in future releases.
>
> If you think this is too specific and not good enough to be added as a patch to the servicemix-eip distribution, then please provide us documentation as to how to include our custom predicate class to our service unit. We tried doing it but it is requiring all other eip classes to be included in the service unit.
>
> Please advise so we can resolve either way.
>
>
>>Routing based on message property and set new property on the message in EIP content based router
>>-------------------------------------------------------------------------------------------------
>>
>> Key: SM-1044
>> URL: https://issues.apache.org/activemq/browse/SM-1044
>> Project: ServiceMix
>> Issue Type: New Feature
>> Components: servicemix-eip
>> Affects Versions: 3.1
>> Environment: Windows, JBoss-4.0.4-GA using Servicemix deployer
>> Reporter: Srivatsan Sridharan
>> Priority: Minor
>> Attachments: SwitchPredicate.java, XPathPredicate.java
>>
>>
>>SwitchPredicate.java (available in Servicemix trunk) routes based on the (boolean) value of the property set on the message exchange. It would be good to have it
>>1) route based on the value (not particularly boolean) of a property set on the message.
>>2) set additional property on the message when the evaluation of property value is true.
>>SwitchPredicate.java attached herewith has the changes to address the above.
>>
>>XPathPredicate.java attached herewith has the changes to set additional property in the ContentBasedRouter.
>>Please let me know if this is the right approach.
>
>
--
Thomas Termin
_______________________________
blue elephant systems GmbH
Wollgrasweg 49
D-70599 Stuttgart
Tel : (+49) 0711 - 45 10 17 676
Fax : (+49) 0711 - 45 10 17 573
WWW : http://www.blue-elephant-systems.com
Email : Thomas.Termin@blue-elephant-systems.com
blue elephant systems GmbH
Firmensitz : Wollgrasweg 49, D-70599 Stuttgart
Registergericht : Amtsgericht Stuttgart, HRB 24106
Geschäftsführer : Holger Dietrich, Thomas Gentsch, Joachim Hoernle
[jira] Commented: (SM-1044) Routing based on message property and
set new property on the message in EIP content based router
Posted by "Vinod Chhabria (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40120 ]
Vinod Chhabria commented on SM-1044:
------------------------------------
We think this is a good enhancement to the existing predicate classes. Can you please approve so we can go ahead and add this to our servicemix installation. We do not want to apply any patch that will not be available in future releases.
If you think this is too specific and not good enough to be added as a patch to the servicemix-eip distribution, then please provide us documentation as to how to include our custom predicate class to our service unit. We tried doing it but it is requiring all other eip classes to be included in the service unit.
Please advise so we can resolve either way.
> Routing based on message property and set new property on the message in EIP content based router
> -------------------------------------------------------------------------------------------------
>
> Key: SM-1044
> URL: https://issues.apache.org/activemq/browse/SM-1044
> Project: ServiceMix
> Issue Type: New Feature
> Components: servicemix-eip
> Affects Versions: 3.1
> Environment: Windows, JBoss-4.0.4-GA using Servicemix deployer
> Reporter: Srivatsan Sridharan
> Priority: Minor
> Attachments: SwitchPredicate.java, XPathPredicate.java
>
>
> SwitchPredicate.java (available in Servicemix trunk) routes based on the (boolean) value of the property set on the message exchange. It would be good to have it
> 1) route based on the value (not particularly boolean) of a property set on the message.
> 2) set additional property on the message when the evaluation of property value is true.
> SwitchPredicate.java attached herewith has the changes to address the above.
>
> XPathPredicate.java attached herewith has the changes to set additional property in the ContentBasedRouter.
> Please let me know if this is the right approach.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SM-1044) Routing based on message property and set
new property on the message in EIP content based router
Posted by "Srivatsan Sridharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Srivatsan Sridharan closed SM-1044.
-----------------------------------
Resolution: Fixed
Implemented custom Predicates.
> Routing based on message property and set new property on the message in EIP content based router
> -------------------------------------------------------------------------------------------------
>
> Key: SM-1044
> URL: https://issues.apache.org/activemq/browse/SM-1044
> Project: ServiceMix
> Issue Type: New Feature
> Components: servicemix-eip
> Affects Versions: 3.1
> Environment: Windows, JBoss-4.0.4-GA using Servicemix deployer
> Reporter: Srivatsan Sridharan
> Priority: Minor
> Attachments: SwitchPredicate.java, XPathPredicate.java
>
>
> SwitchPredicate.java (available in Servicemix trunk) routes based on the (boolean) value of the property set on the message exchange. It would be good to have it
> 1) route based on the value (not particularly boolean) of a property set on the message.
> 2) set additional property on the message when the evaluation of property value is true.
> SwitchPredicate.java attached herewith has the changes to address the above.
>
> XPathPredicate.java attached herewith has the changes to set additional property in the ContentBasedRouter.
> Please let me know if this is the right approach.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-1044) Routing based on message property and
set new property on the message in EIP content based router
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40258 ]
Guillaume Nodet commented on SM-1044:
-------------------------------------
Sorry about the delay ...
I agree about the route based on a value, but it should be done in a new predicate that would check the value of the property on the exchange.
It could be done easily with a PropertyExpression, so we would have a PropertyPredicate (as we have an XPathPredicate).
Wanna provide a patch for this one ? I'd be glad to include it.
As for the properties that are set by the predicate, i don't really like that. Predicates are meant to not mutate the exchange.
You can do that in your own predicate as you suggested yourself.
Can you please expose your exact problems in doing so ?
> Routing based on message property and set new property on the message in EIP content based router
> -------------------------------------------------------------------------------------------------
>
> Key: SM-1044
> URL: https://issues.apache.org/activemq/browse/SM-1044
> Project: ServiceMix
> Issue Type: New Feature
> Components: servicemix-eip
> Affects Versions: 3.1
> Environment: Windows, JBoss-4.0.4-GA using Servicemix deployer
> Reporter: Srivatsan Sridharan
> Priority: Minor
> Attachments: SwitchPredicate.java, XPathPredicate.java
>
>
> SwitchPredicate.java (available in Servicemix trunk) routes based on the (boolean) value of the property set on the message exchange. It would be good to have it
> 1) route based on the value (not particularly boolean) of a property set on the message.
> 2) set additional property on the message when the evaluation of property value is true.
> SwitchPredicate.java attached herewith has the changes to address the above.
>
> XPathPredicate.java attached herewith has the changes to set additional property in the ContentBasedRouter.
> Please let me know if this is the right approach.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.