You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/05/18 07:43:18 UTC

[GitHub] [iceberg] marton-bod commented on pull request #2598: MR: remove Hive dependencies on Iceberg de/serialization utility functions

marton-bod commented on pull request #2598:
URL: https://github.com/apache/iceberg/pull/2598#issuecomment-842937212


   Thanks for this patch! I think the refactor makes sense, even if there were no classpath issues. One thing though, I think we should also add their opposite, serialization operations into this new class. For example, we serialize the table into the config in `HiveIcebergStorageHandler#overlayTableProperties`, which would now belong more naturally to this util class as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org