You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/21 07:06:16 UTC

[GitHub] [kafka] showuon edited a comment on pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

showuon edited a comment on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-731520316


   @ableegoldman , thanks for pointing it out. After investigation, I found the test `StreamsUncaughtExceptionHandlerIntegrationTest.shouldShutdownThreadUsingOldHandler` failed is because we set 2 stream threads for this test. So when we got the `uncaughtException`, we shutdown the thread, and **rebalancing** to the other thread. And we have to wait for rebalancing completes, and later another exception thrown in the other thread, then the stream will turn into `ERROR` state, which is why it is so flaky. 
   
   I default set to 1 stream thread in this test since other tests will set to the expected thread number before testing.
   
   The fix is in this commit: https://github.com/apache/kafka/pull/9629/commits/75e2d261aff819ed8c7a1ec154d64a8e2e1c626e. Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org