[jira] [Commented] (BEAM-10479) UDF / UDAF support for ZetaSQLQueryPlanner

["Beam JIRA Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-10479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194793#comment-17194793 ] 

Beam JIRA Bot commented on BEAM-10479:
--------------------------------------

This issue is P2 but has been unassigned without any comment for 60 days so it has been labeled "stale-P2". If this issue is still affecting you, we care! Please comment and remove the label. Otherwise, in 14 days the issue will be moved to P3.

Please see https://beam.apache.org/contribute/jira-priorities/ for a detailed explanation of what these priorities mean.


> UDF / UDAF support for ZetaSQLQueryPlanner
> ------------------------------------------
>
>                 Key: BEAM-10479
>                 URL: https://issues.apache.org/jira/browse/BEAM-10479
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql-zetasql
>            Reporter: Jacob Ferriero
>            Priority: P2
>              Labels: stale-P2
>
> [BeamSqlDslUdfUdafTest | https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslUdfUdafTest.java] should be refactored so each test runs against all supported Query Planners (namely Calcite and Zeta SQL).
> This could be achieved without code duplication by using Parameterized tests and having each test run with both query planners (and easily support adding more QueryPlanners in the future if necessary).
> {code:java}
> import org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner;
> import org.apache.beam.sdk.extensions.sql.impl.CalciteQueryPlanner;
> @RunWith(Parameterized.class)
> public class BeamSqlDslUdfUdafTest extends BeamSqlDslBase {
>    public QueryPlanner planner;
>   @Parameters(name = "{0}")
>   public static Collection<Class<? extends QueryPlanner>> planners(){
>     return Arrays.asList(
>       CalciteQueryPlanner.class,
>       ZetaSQLQueryPlanner.class)
>   }
>   BeamSqlDslUdfUdafTest(Class<? extends QueryPlanner> planner){
>     this.planner = planner;
>   }
>   // TODO refactor each test that run SqlTransform::query to use SqlTransform::withQueryPlannerClass(this.planner)
>   ...
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)